Create Task
Maniphest T107717

Image Width and Image Height seem to be mixed up in image metadata (file Exif.php?)
Closed, ResolvedPublic
Actions

Description

Example: See image https://commons.wikimedia.org/wiki/File:Lillsj%C3%B6n_2015.jpg

Under Metadata click on "Show extended details"

There it says:
Image height 4,608 px
Image width 3.456 px

It should be the other way around, i.e.
Image width 4,608 px
Image width 3,456 px

Suggestion from [[user:LX]] is that the code around line 177 in the file Exif.php, see http://git.wikimedia.org/blob/mediawiki%2Fcore.git/8dff5095da045442f257a2395c31216e1469bd71/includes%2Fmedia%2FExif.php#L177 might be the cause of this problem.

Details

SubjectRepoBranchLines +/-
Swap exif-pixelydimension and exif-pixelxdimension messagesmediawiki/coremaster+341 -341
Customize query in gerrit

Event Timeline

Larske created this task.Aug 2 2015, 9:26 PM
Larske raised the priority of this task from to Medium.
Larske updated the task description. (Show Details)
Larske added a project: Commons.
Larske subscribed.
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald TranscriptAug 2 2015, 9:26 PM
Larske updated the task description. (Show Details)Aug 2 2015, 9:33 PM
Larske set Security to None.
Larske updated the task description. (Show Details)
Aklapper lowered the priority of this task from Medium to Low.Aug 3 2015, 8:27 AM
Aklapper added a project: MediaWiki-File-management.
Restricted Application added a project: Multimedia. · View Herald TranscriptAug 3 2015, 8:27 AM
zhuyifei1999 subscribed.Aug 9 2015, 8:15 AM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 9 2015, 8:15 AM
zhuyifei1999 moved this task from Incoming to Backlog on the Commons board.Aug 9 2015, 8:16 AM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 5:51 PM
matmarex claimed this task.Dec 23 2015, 10:26 PM
matmarex subscribed.

It does seem like we have width and height switched around… haha.

	"exif-pixelydimension": "Image width",
	"exif-pixelxdimension": "Image height",
gerritbot subscribed.Apr 5 2016, 10:19 PM

Change 281826 had a related patch set uploaded (by Bartosz Dziewoński):
Swap exif-pixelydimension and exif-pixelxdimension messages

https://gerrit.wikimedia.org/r/281826

gerritbot added a project: Patch-For-Review.Apr 5 2016, 10:19 PM
gerritbot added a comment.Apr 11 2016, 1:57 AM

Change 281826 merged by jenkins-bot:
Swap exif-pixelydimension and exif-pixelxdimension messages

https://gerrit.wikimedia.org/r/281826

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-04-12_(1.27.0-wmf.21)).Apr 11 2016, 2:00 AM
matmarex closed this task as Resolved.Apr 11 2016, 12:47 PM
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits