VE should wait for global.js before init
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Schnark
	Feb 1 2017, 9:12 AM

Description

Currently, VE waits with initialization until site and user js has been loaded and executed (function getTarget in ve.init.mw.DesktipArticleTarget.init.js), but not for the global.js from Extension:GlobalCssJs.

Waiting for these modules is necessary to make it possible to define plugins: When VE starts right away (because you opened the page in a new tab, or edited from a non-standard view) these modules only load after VE has started initialization. This currently means that plugins defined in global.js may be missing, because their definition comes too late.

Details

	Subject	Repo	Branch	Lines +/-
	DesktopArticleTarget: Make the waiting module list extensible	mediawiki/extensions/VisualEditor	master	+7 -3
	Register our modules as preload requirements for VisualEditor if present	mediawiki/extensions/GlobalCssJs	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: T161970: ext.visualEditor.desktopArticleTarget.init errors if I call jQuery in global.js
T157113: VE plugins from user scripts not always loaded

Event Timeline

Schnark created this task.Feb 1 2017, 9:12 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 1 2017, 9:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 335462 had a related patch set uploaded (by DLynch):
DesktopArticleTarget: wait for global.js as well

https://gerrit.wikimedia.org/r/335462

gerritbot added a project: Patch-For-Review.Feb 1 2017, 5:00 PM

Jdforrester-WMF assigned this task to DLynch.Feb 1 2017, 5:57 PM

Jdforrester-WMF triaged this task as Low priority.

Jdforrester-WMF added a project: GlobalCssJs.

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

• Esanders mentioned this in T157113: VE plugins from user scripts not always loaded.Feb 8 2017, 5:56 PM

Change 343226 had a related patch set uploaded (by Jforrester):
[mediawiki/extensions/GlobalCssJs] Register our modules as preload requirements for VisualEditor if present

https://gerrit.wikimedia.org/r/343226

Change 335462 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Make the waiting module list extensible

https://gerrit.wikimedia.org/r/335462

Change 343226 merged by jenkins-bot:
[mediawiki/extensions/GlobalCssJs@master] Register our modules as preload requirements for VisualEditor if present

https://gerrit.wikimedia.org/r/343226

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)).Mar 28 2017, 4:00 PM

Jdforrester-WMF closed this task as Resolved.Mar 28 2017, 4:15 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 28 2017, 4:15 PM

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Mar 28 2017, 11:44 PM

vjudge404 mentioned this in T161970: ext.visualEditor.desktopArticleTarget.init errors if I call jQuery in global.js.Apr 2 2017, 4:31 AM

Ryasmeen moved this task from Verified to Non verifiable/Task on the User-Ryasmeen board.Apr 13 2017, 9:14 PM