Create Task
Maniphest T161257

When redrawing the page to a new revision, please update mw.config.get('wgRevisionId')
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Otherwise things that depend on it (e.g. VisualEditor) will act on the wrong page.

Details

SubjectRepoBranchLines +/-
Update wgRevisionId when changed by slidermediawiki/extensions/RevisionSlidermaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Mar 23 2017, 9:34 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMar 23 2017, 9:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Mar 23 2017, 9:34 PM
gerritbot subscribed.Mar 23 2017, 9:48 PM

Change 344527 had a related patch set uploaded (by Esanders):
[mediawiki/extensions/RevisionSlider@master] Update wgRevisionId when changed by slider

https://gerrit.wikimedia.org/r/344527

gerritbot added a project: Patch-For-Review.Mar 23 2017, 9:48 PM
• Esanders mentioned this in rERSLb00f11ebd214: Update wgRevisionId when changed by slider.Mar 23 2017, 9:49 PM
• Esanders subscribed.Mar 23 2017, 9:50 PM

Actually on investigation, VE doesn't currently launch directly on diff pages at the moment, so the current edit link patching is sufficient, but this is still a good thing to do for the future.

gerritbot added a comment.Mar 24 2017, 9:25 AM

Change 344527 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Update wgRevisionId when changed by slider

https://gerrit.wikimedia.org/r/344527

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)).Mar 24 2017, 10:00 AM
Jdforrester-WMF closed this task as Resolved.Mar 25 2017, 12:00 AM
Jdforrester-WMF assigned this task to • Esanders.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF removed a project: Patch-For-Review.

Thanks!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 25 2017, 12:00 AM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Mar 28 2017, 11:27 PM
Ryasmeen moved this task from Verified to Non verifiable/Task on the User-Ryasmeen board.Apr 13 2017, 9:15 PM
Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Jun 6 2017, 10:15 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits