Create Task
Maniphest T258420

MenuTagMultiselect adds items twice if specified as options and selected options
Closed, ResolvedPublic
Actions

Description

The MenuTagMultiselectWidget has the following config (among others):

  • options specifies the options that can appear in the menu
  • selected specifies the options that are pre-selected

I would expect options to be a superset of selected, but if an item is specified in both, it appears twice in the menu, with the second version appearing blank:

image.png (555×746 px, 33 KB)

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.40.1mediawiki/coremaster+1 K -1 K
OO.ui.MenuTagMultiselectWidget: Fix handling of options configsoojs/uimaster+24 -11
Customize query in gerrit

Event Timeline

Tchanders created this task.Jul 20 2020, 5:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2020, 5:03 PM
Tchanders claimed this task.Jul 31 2020, 3:25 PM
gerritbot added a comment.Jul 31 2020, 6:59 PM

Change 617753 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] OO.ui.MenuTagMultiselectWidget: Fix handling of options configs

https://gerrit.wikimedia.org/r/617753

gerritbot added a project: Patch-For-Review.Jul 31 2020, 6:59 PM
gerritbot added a comment.Aug 5 2020, 5:29 PM

Change 617753 merged by jenkins-bot:
[oojs/ui@master] OO.ui.MenuTagMultiselectWidget: Fix handling of options configs

https://gerrit.wikimedia.org/r/617753

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2020, 6:10 PM
gerritbot added a comment.Aug 7 2020, 1:36 PM

Change 618983 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.1

https://gerrit.wikimedia.org/r/618983

gerritbot added a project: Patch-For-Review.Aug 7 2020, 1:36 PM
gerritbot added a comment.Aug 7 2020, 2:46 PM

Change 618983 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.1

https://gerrit.wikimedia.org/r/618983

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Aug 12 2020, 9:39 PM
Volker_E closed this task as Resolved.Aug 12 2020, 9:42 PM
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Reviewing to OOUI-0.40.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.40.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits