MenuTagMultiselectWidget removes selected tag if invalid input is entered
Closed, ResolvedPublic2 Estimated Story PointsAug 11 2020
Actions

Assigned To

Authored By

	Tchanders
	Jul 21 2020, 12:49 PM

Description

Steps to reproduce:

Go to the demo for MenuTagMultiselectWidget (initially selected, preset options) (may need to scroll down and find this item)
Type an invalid value into the input (i.e. a value that is not in the dropdown list)
Press enter

Expected:

The exact behaviour depends on other config, but at the very least the existing tags should not be affected

Actual:

The last existing tag is removed, along with the entered text

Details

Due Date: Aug 11 2020, 4:00 AM

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.40.1	mediawiki/core	master	+1 K -1 K
	OO.ui.MenuSelectWidget: Don't handle keydown if no items are visible	oojs/ui	master	+12 -13

Customize query in gerrit

Related Objects

Mentioned In: T248530: CU 2.0 - Block: Select users and IPs to block
Mentioned Here: rMWea8438f8cf12: Merge "Avoid SpecialPage::getTitleValueFor in LinkRenderer"

Event Timeline

Tchanders created this task.Jul 21 2020, 12:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2020, 12:49 PM

dom_walden mentioned this in T248530: CU 2.0 - Block: Select users and IPs to block.Jul 21 2020, 4:17 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Jul 21 2020, 6:16 PM

ARamirez_WMF set the point value for this task to 2.Jul 22 2020, 4:29 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jul 29 2020, 5:31 PM

ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

ARamirez_WMF set Due Date to Aug 11 2020, 4:00 AM.Jul 29 2020, 5:44 PM

ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Tchanders claimed this task.Jul 30 2020, 11:20 AM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 617504 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] OO.ui.MenuSelectWidget: Don't handle keydown if no items are visible

https://gerrit.wikimedia.org/r/617504

gerritbot added a project: Patch-For-Review.Jul 30 2020, 5:37 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jul 30 2020, 7:49 PM

Change 617504 merged by jenkins-bot:
[oojs/ui@master] OO.ui.MenuSelectWidget: Don't handle keydown if no items are visible

https://gerrit.wikimedia.org/r/617504

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2020, 1:10 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Jul 31 2020, 2:22 PM

I have not been able to get this working locally.

It may have to wait for a new OOUI release to be tested.

FYI, example of current behaviour:

dropdown.mp4615 KBDownload

Change 618983 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.1

https://gerrit.wikimedia.org/r/618983

gerritbot added a project: Patch-For-Review.Aug 7 2020, 1:36 PM

Change 618983 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.1

https://gerrit.wikimedia.org/r/618983

Maintenance_bot removed a project: Patch-For-Review.Aug 7 2020, 3:11 PM

I can no longer reproduce the bug in the description.

Otherwise, the CheckUser block form (which uses this widget) behaves the same as before.

Test environment Local vagrant MediaWiki 1.36.0-alpha (ea8438f) CheckUser 2.5 (900fff7).

Niharika closed this task as Resolved.Aug 24 2020, 10:37 PM

	F31955852: dropdown.mp4
	Jul 31 2020, 5:51 PM

MenuTagMultiselectWidget removes selected tag if invalid input is enteredClosed, ResolvedPublic2 Estimated Story PointsAug 11 2020Actions

Description

Details

Related Objects

Event Timeline

MenuTagMultiselectWidget removes selected tag if invalid input is entered
Closed, ResolvedPublic2 Estimated Story PointsAug 11 2020
Actions