| mwilliams | |
| Jul 28 2020, 6:30 PM |
| F32088939: Screen Shot 2020-08-12 at 5.33.44 PM.png | |
| Aug 13 2020, 12:40 AM |
| F32088934: Screen Shot 2020-08-12 at 5.33.03 PM.png | |
| Aug 13 2020, 12:40 AM |
| F32037077: Screen Shot 2020-08-10 at 5.47.39 PM.png | |
| Aug 11 2020, 12:51 AM |
| F32037068: Screen Shot 2020-08-10 at 5.47.51 PM.png | |
| Aug 11 2020, 12:51 AM |
| F32037085: Screen Shot 2020-08-10 at 5.48.05 PM.png | |
| Aug 11 2020, 12:51 AM |
| F31952036: Screen Shot 2020-07-28 at 12.35.02 PM.png | |
| Jul 28 2020, 6:36 PM |
| F31952025: Screen Shot 2020-07-28 at 12.26.41 PM.png | |
| Jul 28 2020, 6:30 PM |
| F31952024: Screen Shot 2020-07-28 at 12.27.50 PM.png | |
| Jul 28 2020, 6:30 PM |
Currently we have a bit of an awkward layout with the audio player inside of the quick view
Adding margin (32px from the top of the player to the top of the white card and 24px below the player to the file name) around the audio player, centering the player in the space, and removing the bg color we use for images with different aspect ratios could make this layout less awkward.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix audio player height issue and update layout | mediawiki/extensions/WikibaseMediaInfo | master | +18 -3 |
Change 618873 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix audio player height issue and update layout
Change 618873 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix audio player height issue and update layout
The QuickView layout looks different in different browser (assuming it's all within acceptable range of expectations).
| FF | Chrome | Safari |
 |  |  |
@Etonkovidova that's expected behavior for now – eventually we plan to introduce the new Audio/Video player library which should unify the experience, but for now we are relying on how each browser natively handles <audio> and <video> elements.
Thanks @egardner for clarification!
Checked on commons wmf.4; the specs in https://gerrit.wikimedia.org/r/618873 seem to be in place.
Ping @mwilliams - it'd be great to confirm that all looks as it should be:
| FF | Chrome |
 |  |