PHP warning from BaseTemplate::getFooterLinks() when $validFooterLinks is empty on PHP < 7.4
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Oct 11 2020, 10:00 PM

Description

		if ( $option == 'flat' ) {
			// fold footerlinks into a single array using a bit of trickery
			$validFooterLinks = array_merge( ...array_values( $validFooterLinks ) );
		}

In 1.31 similar code that uses call_user_func_array has the same problem.

On PHP < 7.4, array_merge will emit a warning if passed no arguments (https://3v4l.org/I4Bpc).

This was reported downstream at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971985.

Details

Subject	Repo	Branch	Lines +/-
BaseTemplate: Guard against passing zero arg to array_merge()	mediawiki/core	master	+1 -1
BaseTemplate: Guard against passing zero arg to array_merge()	mediawiki/core	REL1_35	+1 -1
BaseTemplate: Guard against passing zero arg to array_merge()	mediawiki/core	REL1_31	+1 -1

Customize query in gerrit

Event Timeline

Legoktm created this task.Oct 11 2020, 10:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 11 2020, 10:00 PM

DannyS712 subscribed.Oct 11 2020, 11:28 PM

Change 633474 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Guard against passing zero arg to array_merge()

https://gerrit.wikimedia.org/r/633474

gerritbot added a project: Patch-For-Review.Oct 12 2020, 7:37 AM

Ammarpad claimed this task.Oct 12 2020, 5:29 PM

Change 636705 had a related patch set uploaded (by Reedy; owner: Ammarpad):
[mediawiki/core@REL1_35] BaseTemplate: Guard against passing zero arg to array_merge()

https://gerrit.wikimedia.org/r/636705

Change 636786 had a related patch set uploaded (by Reedy; owner: Ammarpad):
[mediawiki/core@REL1_31] BaseTemplate: Guard against passing zero arg to array_merge()

https://gerrit.wikimedia.org/r/636786

Change 636786 merged by jenkins-bot:
[mediawiki/core@REL1_31] BaseTemplate: Guard against passing zero arg to array_merge()

https://gerrit.wikimedia.org/r/636786

Change 636705 merged by jenkins-bot:
[mediawiki/core@REL1_35] BaseTemplate: Guard against passing zero arg to array_merge()

https://gerrit.wikimedia.org/r/636705

ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.35-notes.Oct 28 2020, 1:00 AM

Reedy moved this task from Backlog to Done on the MW-1.31-release board.Oct 28 2020, 1:10 AM

Reedy moved this task from Blocker to Done on the MW-1.35-release board.

Change 633474 merged by jenkins-bot:
[mediawiki/core@master] BaseTemplate: Guard against passing zero arg to array_merge()

https://gerrit.wikimedia.org/r/633474

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 28 2020, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 28 2020, 2:10 AM

Reedy removed a project: MW-1.34-release.Nov 30 2020, 10:40 PM

Reedy closed this task as Resolved.Dec 2 2020, 1:50 AM

PHP warning from BaseTemplate::getFooterLinks() when $validFooterLinks is empty on PHP < 7.4Closed, ResolvedPublicActions

Description

Details

Event Timeline

PHP warning from BaseTemplate::getFooterLinks() when $validFooterLinks is empty on PHP < 7.4
Closed, ResolvedPublic
Actions