create approve/de-activate buttons for implementation table on function-viewer page
Closed, ResolvedPublic

Description

admins can approve implementations to move them from proposed to verified, and can also deactivate to move them from verified to proposed.

This should use the codex button group component once it is available (https://phabricator.wikimedia.org/T306025)

Event Timeline

As part of this task we can:

  • Add the button components
  • Trigger an action that will call wikilambda_edit passing the modified function object as a zobject parameter (e.g. if Accept an implementation, add the implementation Zid to the Z8K4 list, if Accept a tester, add the testerZid to the Z8K3 list)

As a future follow-up task (part of G6) we will need to:

  • Handle permissions related to this call, so only admins can make these modifications
  • Handle permissions in the front-end so that only admins can see an active button

Change 824416 had a related patch set uploaded (by EWright; author: EWright):

[mediawiki/extensions/WikiLambda@master] [WIP] Add approve & deactivate buttons, and fix select-all checkbox.

https://gerrit.wikimedia.org/r/824416

Change 824240 had a related patch set uploaded (by Jforrester; author: EWright):

[mediawiki/extensions/WikiLambda@master] Add actions to attach/detach testers and implementations.

https://gerrit.wikimedia.org/r/824240

Change 824240 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add actions to attach/detach testers and implementations.

https://gerrit.wikimedia.org/r/824240

Change 824416 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add approve & deactivate buttons, and fix select-all checkbox.

https://gerrit.wikimedia.org/r/824416

Still to do: utilise codex button group component once it is available (https://phabricator.wikimedia.org/T306025)

After chatting with @AAlhazwani-WMF , we have decided to not use button groups for this use case.