User::loadFromSession called before the end of Setup.php
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.39.0-wmf.25
reqId: 6faf354d-8847-4cc5-a764-31b3d956f02d
Find reqId in Logstash

normalized_message

User::loadFromSession called before the end of Setup.php

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.25/includes/user/User.php(383)
#0 /srv/mediawiki/php-1.39.0-wmf.25/includes/user/User.php(1683): User->load()
#1 /srv/mediawiki/php-1.39.0-wmf.25/includes/user/User.php(2329): User->getId()
#2 /srv/mediawiki/php-1.39.0-wmf.25/includes/user/UserOptionsManager.php(597): User->isRegistered()
#3 /srv/mediawiki/php-1.39.0-wmf.25/includes/user/UserOptionsManager.php(498): MediaWiki\User\UserOptionsManager->loadOriginalOptions(User, integer, NULL)
#4 /srv/mediawiki/php-1.39.0-wmf.25/includes/user/UserOptionsManager.php(148): MediaWiki\User\UserOptionsManager->loadUserOptions(User, integer)
#5 /srv/mediawiki/php-1.39.0-wmf.25/extensions/GrowthExperiments/includes/VariantHooks.php(184): MediaWiki\User\UserOptionsManager->getOption(User, string, string)
#6 /srv/mediawiki/php-1.39.0-wmf.25/extensions/GrowthExperiments/includes/VariantHooks.php(125): GrowthExperiments\VariantHooks::getCampaign(RequestContext)
#7 /srv/mediawiki/php-1.39.0-wmf.25/includes/HookContainer/HookContainer.php(160): GrowthExperiments\VariantHooks->onSpecialPage_initList(array)
#8 /srv/mediawiki/php-1.39.0-wmf.25/includes/HookContainer/HookRunner.php(3676): MediaWiki\HookContainer\HookContainer->run(string, array)
#9 /srv/mediawiki/php-1.39.0-wmf.25/includes/specialpage/SpecialPageFactory.php(1163): MediaWiki\HookContainer\HookRunner->onSpecialPage_initList(array)
#10 /srv/mediawiki/php-1.39.0-wmf.25/includes/specialpage/SpecialPageFactory.php(1178): MediaWiki\SpecialPage\SpecialPageFactory->getPageList()
#11 /srv/mediawiki/php-1.39.0-wmf.25/includes/specialpage/SpecialPageFactory.php(1517): MediaWiki\SpecialPage\SpecialPageFactory->getAliasList()
#12 /srv/mediawiki/php-1.39.0-wmf.25/includes/specialpage/SpecialPage.php(149): MediaWiki\SpecialPage\SpecialPageFactory->getLocalNameFor(string, boolean)
#13 /srv/mediawiki/php-1.39.0-wmf.25/includes/specialpage/SpecialPage.php(134): SpecialPage::getTitleValueFor(string, boolean, string)
#14 /srv/mediawiki/php-1.39.0-wmf.25/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php(83): SpecialPage::getTitleFor(string)
#15 /srv/mediawiki/php-1.39.0-wmf.25/extensions/AbuseFilter/includes/AbuseFilterPreAuthenticationProvider.php(66): MediaWiki\Extension\AbuseFilter\AbuseFilterPreAuthenticationProvider->testUser(User, User, boolean)
#16 /srv/mediawiki/php-1.39.0-wmf.25/includes/auth/AuthManager.php(1840): MediaWiki\Extension\AbuseFilter\AbuseFilterPreAuthenticationProvider->testUserForCreation(User, string, array)
#17 /srv/mediawiki/php-1.39.0-wmf.25/includes/Setup.php(546): MediaWiki\Auth\AuthManager->autoCreateUser(User, string, boolean)
#18 /srv/mediawiki/php-1.39.0-wmf.25/includes/WebStart.php(86): require_once(string)
#19 /srv/mediawiki/php-1.39.0-wmf.25/index.php(44): require(string)
#20 /srv/mediawiki/w/index.php(3): require(string)
#21 {main}

Impact

Notes

166,000 of these in the last 30 days. Started with wmf.23, rEGRE8921c7584c49: WelcomeSurvey/VariantHooks: Change hook used for redirection.

Details

Request URL: https://mzn.wikipedia.org/wiki/%D9%81%D8%AF%D8%A7%DB%8C%DB%8C

	Subject	Repo	Branch	Lines +/-
	Avoid errors when VariantHooks::getCampaign is called early	mediawiki/extensions/GrowthExperiments	master	+6 -1

Customize query in gerrit

Related Objects

Mentioned Here: rEGRE8921c7584c49: WelcomeSurvey/VariantHooks: Change hook used for redirection

Event Timeline

kostajh created this task.Aug 22 2022, 9:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2022, 9:09 AM

kostajh triaged this task as High priority.Aug 22 2022, 9:10 AM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh updated the task description. (Show Details)Aug 22 2022, 9:12 AM

We still have campaigns defined in mediawiki-config repo, but as I understand it, none of them are active (cc @KStoller-WMF). If that's the case, then we could remove the onSpecialPage_initList code which is where these errors begin. If we do a campaign in the future, we'll need to figure out a different solution to this.

Change 826129 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Avoid errors when VariantHooks::getCampaign is called early

https://gerrit.wikimedia.org/r/826129

gerritbot added a project: Patch-For-Review.Aug 24 2022, 6:20 AM

In the longer term, we should get rid of the SpecialPage_initList hook, it's called a lot and at unpredictable times. We should move the trigger for customizing the signup page to a core hook.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 24 2022, 9:25 AM

Change 826129 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Avoid errors when VariantHooks::getCampaign is called early

https://gerrit.wikimedia.org/r/826129

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 24 2022, 10:01 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2022, 10:30 AM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 31 2022, 10:11 PM