Create Task
Maniphest T368844

Special:Translate not showing all messages for aggregate groups
Open, HighPublic
Actions

Description

After lots of debugging, I found out the root cause:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1043759/9/messagegroups/AggregateMessageGroup.php added a return statement, which cuts the loop early.

Details

SubjectRepoBranchLines +/-
AggregateMessageGroup: Remove invalid return statementmediawiki/extensions/Translatemaster+0 -1
Customize query in gerrit

Event Timeline

• Nikerabbit created this task.Sun, Jun 30, 7:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSun, Jun 30, 7:13 AM
• Nikerabbit claimed this task.Sun, Jun 30, 7:13 AM
• Nikerabbit triaged this task as Unbreak Now! priority.
• Nikerabbit added projects: LPL Essential (LPL Essential 2024 Jul-Sep), Unplanned-Sprint-Work.
• Nikerabbit lowered the priority of this task from Unbreak Now! to High.Sun, Jun 30, 7:18 AM

I've deployed a hotfix on the server. Please take it from here.

• Nikerabbit renamed this task from Special:Translate now showing all messages for aggregate groups to Special:Translate not showing all messages for aggregate groups.Sun, Jun 30, 7:22 AM
Nemoralis subscribed.Sun, Jun 30, 8:44 AM
gerritbot added a comment.Mon, Jul 1, 4:25 AM

Change #1050813 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] AggregateMessageGroup: Remove invalid return statement

https://gerrit.wikimedia.org/r/1050813

gerritbot added a project: Patch-For-Review.Mon, Jul 1, 4:25 AM
abi_ moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Mon, Jul 1, 4:40 AM
abi_ moved this task from Sprint Backlog to Needs Review on the LPL Essential (LPL Essential 2024 Jul-Sep) board.
gerritbot added a comment.Mon, Jul 1, 6:14 AM

Change #1050813 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AggregateMessageGroup: Remove invalid return statement

https://gerrit.wikimedia.org/r/1050813

abi_ moved this task from Needs Review to Pending Deployment on the LPL Essential (LPL Essential 2024 Jul-Sep) board.Mon, Jul 1, 6:30 AM
Maintenance_bot removed a project: Patch-For-Review.Mon, Jul 1, 6:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Mon, Jul 1, 7:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits