In T329346#9731804, @Novem_Linguae wrote:

We should give some thought to if we want to put this behind a preference or not, and if that preference should default to off or on.

In T355030#9474500, @Novem_Linguae wrote:

The patch is marked as work in progress. Is that correct, or is it ready for review?

unstalled now.

@Novem_Linguae this seems fixed to me on enwiki. Can you check?

Adding Susana, for a code review of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1006902.

In T349886#9565314, @Novem_Linguae wrote:

New idea: Same as the screenshot above, but add an ⓘ icon to the header that, when clicked, displays a tooltip with the stats. This keeps the stats but lets us get rid of the footer, and avoids cluttering the header.

I'd be on board with this. We might even be able to hit the stats api only when the tooltip is requested, as opposed to every time the page is hit.

The list Api being called doesn't have the right param when that particular filter is applied.
It looks like modules/ext.pageTriage.newPagesFeed.vue/stores/settings.js doesn't have the required lines for autopatrolled. The other filters in the "That:" list do work.

In T348743#9294287, @Ladsgroup wrote:

It calls getExternalLB which shouldn't be called outside of rdbms anymore but it's only in tests (https://codesearch.wmcloud.org/things/?q=getExternalLB&files=&excludeFiles=&repos=Extension%3APageTriage) are you sure it's needed? Can you just remove that?

Suggestions from Chlod regarding a way in JS to figure out if a particular extension has been installed:

could check if DT's JS module (ext.discussionTools.init) is "registered" with mw.loader.getState("ext.discussionTools.init"); it'll be null if DT isn't present
there's also other ext.discussionTools.* modules that you can test for
this might be worth checking on the backend side instead, though, and fed into mw.config, considering that there's an additional requirement: topic subscription is enabled, both on-wiki and for the user

Seems to be ok now. e.g. https://en.wikipedia.org/w/index.php?title=Shamshabad%2C_Madhya_Pradesh&diff=1199175004&oldid=1199173347

Unsure what to do when there are multiple tags added , but one or more don't have skipNotification=true. This isn't a problem for redirects since only the redirect tags are shown to the reviewer and for none of them we need to notify the creator. But, it could be a problem in the future when the skipNotification param is added to article tags as well. My current thought is that if any of the tags need notification, then notify about all.

All clear. Closing.

Yep, your image is what I was proposing. In the context of T343445: Do not notify user about redirect templates the patch writer would probably have to add a param skipNotification=true for every relevant redirect tag, which is most/all of them.

https://en.wikipedia.org/w/api.php?action=pagetriagestats&show_predicted_issues_none=1&non_autoconfirmed_users=1 doesn't show an error now

Changing the link to red is not yet done

There were about 30 entries in https://nppbrowser.toolforge.org/index.php?mode=NPP&q=Badtitle which I've now cleared (by doing null edits). If after a week there are no new entries for this search, we should consider this bug as resolved.

This is done since it isn't user-facing yet, and the code has been merged.

The common section was removed from the toolbar and then re-added after some complaints from the community. I'm not sure if this ticket should be marked as declined or resolved.