Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdi tag should be marked as inline, not block #616

Closed
behnam opened this issue Sep 26, 2017 · 3 comments
Closed

bdi tag should be marked as inline, not block #616

behnam opened this issue Sep 26, 2017 · 3 comments
Labels
Bug

Comments

@behnam
Copy link

behnam commented Sep 26, 2017

Current Config:

tidy-html5/src/tags.c

Line 300 in 0016e00

{ TidyTag_BDI, "bdi", VERS_ELEM_BDI, &TY_(W3CAttrsFor_BDI)[0], (CM_BLOCK), TY_(ParseBlock), NULL },

From the spec:

The bdi element represents a span of text that is to be isolated from its surroundings for the purposes of bidirectional text formatting.

The language and example clearly show that bdi is an inline element and not a block element.

Is there any reason this tag is being treated as block element in tidy?
@behnam behnam changed the title bidi tag should be marked as inline, not block Sep 26, 2017
@behnam behnam mentioned this issue Sep 26, 2017
Closed
@balthisar balthisar added the Bug label Sep 28, 2017
@balthisar
Copy link
Member

Confirmed.
balthisar added a commit that referenced this issue Sep 29, 2017
@balthisar
Address #616
d312969 
  - Fix the declaration and parser for the bdi tag.
@balthisar
Copy link
Member

Added candidate #620. This is a simple change, and so will merge in a day or so unless objections are raised.
@balthisar
Copy link
Member

@behnam, confirming that this is merged and live now, so closing this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug
2 participants
@behnam @balthisar