Create Task
Maniphest T142976

Talk icon behaviour in beta different to stable. In stable it isn't loaded in non-RL-capable UAs
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Nicholas.tsg
Authored By
phuedx
Aug 15 2016, 10:38 AM
Tags
Referenced Files
F4869220: T142976 Samsung Galaxy Tab 4.png
Nov 27 2016, 9:20 PM
F4869222: T142976 Samsung Galaxy Tab 4 Beta Mode.png
Nov 27 2016, 9:20 PM
F4869232: T142976 iPad Air 2 (iOS 10.2) Beta Mode.PNG
Nov 27 2016, 9:20 PM
F4869229: T142976 iPad Air 2 (iOS 10.2).PNG
Nov 27 2016, 9:20 PM
F4819737: Screen Shot 2016-11-21 at 16.31.02.png
Nov 21 2016, 9:32 PM
F4364265: Screen Shot 2016-08-15 at 11.34.37.png
Aug 15 2016, 10:38 AM
Subscribers
Aklapper
• bmansurov
gerritbot
Jdlrobson
• jhobs
MBinder_WMF
• Nirzar
View All 10 Subscribers

Description

Background
From T142594 (by @jhobs):

Repro steps:

For those who like screenshots:

Screen Shot 2016-08-15 at 11.34.37.png (167×356 px, 33 KB)

Acceptance Criteria

  • Enable everywhere (for logged in users), remove icon from button
  • Do not feature flag

Test plan

  • Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Barack_Obama and login.
  • Scroll down the page and and look for the "Discussion" button. Make sure that the button contains only the word "Discussion" and no icons (as seen in this screenshot:
    Screen Shot 2016-11-21 at 16.31.02.png (112×348 px, 8 KB)
    )
  • Repeat the above steps when in beta mode.

Details

SubjectRepoBranchLines +/-
Don't show icon on talk buttonmediawiki/extensions/MobileFrontendmaster+1 -13
Load skins.minerva.icons.images.variants in stablemediawiki/extensions/MobileFrontendmaster+1 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

phuedx created this task.Aug 15 2016, 10:38 AM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptAug 15 2016, 10:38 AM
phuedx mentioned this in T142594: Page actions displayed when action isn't view.Aug 15 2016, 10:39 AM
• bmansurov added a comment.Aug 15 2016, 3:30 PM

Not that it matters, but T142594 is not by me.

phuedx updated the task description. (Show Details)Aug 15 2016, 4:05 PM
phuedx added a subscriber: • jhobs.
Jdlrobson subscribed.Aug 15 2016, 5:00 PM

Yup. It needs to be bundled up with the edit icon and watchstar, but note any icon loaded without JS does impact first paint.

• bmansurov added a comment.Aug 15 2016, 5:01 PM

Aren't those icons in stable, and this one in beta?

• jhobs added a project: Web-Team-Backlog.Aug 15 2016, 5:11 PM
• Jhernandez triaged this task as Medium priority.Aug 17 2016, 3:18 PM
• Jhernandez moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.Aug 25 2016, 9:30 PM
Jdlrobson added a subscriber: • Nirzar.

Given the height difference do we even want this icon here @Nirzar ?

Jdlrobson added a project: Design.Sep 22 2016, 8:50 PM
MBinder_WMF moved this task from Needs Prioritization to Design on the Web-Team-Backlog board.Sep 29 2016, 10:46 PM
MBinder_WMF edited projects, added Web-Team-Backlog (Design); removed Web-Team-Backlog.
Jdlrobson mentioned this in T147944: [EPIC] Remove SkinMinervaBeta class.Oct 12 2016, 5:42 PM
gerritbot subscribed.Oct 12 2016, 6:10 PM

Change 315541 had a related patch set uploaded (by Jdlrobson):
Load skins.minerva.icons.images.variants in stable

https://gerrit.wikimedia.org/r/315541

gerritbot added a project: Patch-For-Review.Oct 12 2016, 6:10 PM
Jdlrobson renamed this task from Talk icon isn't loaded in non-RL-capable UAs to Talk icon behaviour in beta different to stable. In stable it isn't loaded in non-RL-capable UAs.Oct 14 2016, 4:29 PM
Jdlrobson added a parent task: T147944: [EPIC] Remove SkinMinervaBeta class.
phuedx added a project: Reading-Web-Sprint-83-Y?.Oct 17 2016, 9:59 AM
phuedx added subscribers: ovasileva, MBinder_WMF.

Since I've just reviewed rEMFR7b68671ccdec: Load skins.minerva.icons.images.variants in stable, I feel like this should be brought into the sprint for visibility /cc @ovasileva @MBinder_WMF

phuedx assigned this task to Jdlrobson.Oct 17 2016, 9:59 AM
phuedx moved this task from Needs Analysis to Needs More Work on the Reading-Web-Sprint-83-Y? board.
ovasileva added a comment.Oct 17 2016, 10:45 AM

@phuedx - sounds good.

Jdlrobson added a project: Unplanned-Sprint-Work.EditedOct 17 2016, 5:04 PM

(although I should note I'm not planning to complete this work this sprint due to still waiting on @Nirzar for an answer to https://phabricator.wikimedia.org/T142976#2584080)

Jdlrobson added a comment.Oct 18 2016, 12:05 AM

@Nirzar I also notice that we show a blue icon on the user page but a gray icon on a page in the main namespace. Should these be different colours?

Jdlrobson reassigned this task from Jdlrobson to • Nirzar.Oct 18 2016, 12:06 AM
Jdlrobson moved this task from Needs More Work to Needs Analysis on the Reading-Web-Sprint-83-Y? board.
• Nirzar added a comment.Oct 18 2016, 12:09 AM

user page is more of a link . and this one is a button.

actually i don't mind getting rid of the icon if it makes it easier. we removed the language button anyways.

Jdlrobson added a comment.Oct 18 2016, 12:13 AM

Both are just as easy - it simply depends what you prefer :)

gerritbot added a comment.Nov 9 2016, 3:29 PM

Change 315541 abandoned by Jdlrobson:
Load skins.minerva.icons.images.variants in stable

Reason:
To be worked on later...

https://gerrit.wikimedia.org/r/315541

ovasileva added a project: Reading-Web-Sprint-86-🔪🦃.Nov 11 2016, 4:34 PM
ovasileva updated the task description. (Show Details)Nov 11 2016, 4:40 PM
ovasileva moved this task from Design to Upcoming on the Web-Team-Backlog board.
ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).
MBinder_WMF removed a project: Unplanned-Sprint-Work.Nov 15 2016, 5:07 PM
ovasileva updated the task description. (Show Details)Nov 15 2016, 5:12 PM
ovasileva removed a project: Patch-For-Review.
ovasileva updated the task description. (Show Details)Nov 15 2016, 5:18 PM
ovasileva set the point value for this task to 2.Nov 15 2016, 5:20 PM
gerritbot added a comment.Nov 15 2016, 5:24 PM

Change 321692 had a related patch set uploaded (by Jdlrobson):
Don't show icon on talk button

https://gerrit.wikimedia.org/r/321692

gerritbot added a project: Patch-For-Review.Nov 15 2016, 5:24 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-86-🔪🦃 board.Nov 21 2016, 5:13 PM
phuedx reassigned this task from • Nirzar to Jdlrobson.Nov 21 2016, 5:36 PM
phuedx moved this task from Code Review to Needs More Work on the Reading-Web-Sprint-86-🔪🦃 board.
Jdlrobson moved this task from Needs More Work to Code Review on the Reading-Web-Sprint-86-🔪🦃 board.Nov 21 2016, 6:25 PM
ovasileva moved this task from Upcoming to 2016-17 Q2 on the Web-Team-Backlog board.Nov 21 2016, 7:47 PM
• bmansurov reassigned this task from Jdlrobson to Nicholas.tsg.Nov 21 2016, 9:32 PM
• bmansurov updated the task description. (Show Details)
• bmansurov moved this task from Code Review to Needs QA on the Reading-Web-Sprint-86-🔪🦃 board.
gerritbot added a comment.Nov 21 2016, 9:38 PM

Change 321692 merged by jenkins-bot:
Don't show icon on talk button

https://gerrit.wikimedia.org/r/321692

Jdlrobson removed a project: Patch-For-Review.Nov 22 2016, 6:52 PM
Nicholas.tsg added a comment.Nov 27 2016, 9:20 PM

I have consistently seen no icon on the "Discussion" button when testing the following environments:

Samsung Galaxy Tab 4 stable

T142976 Samsung Galaxy Tab 4.png (1×800 px, 160 KB)

Samsung Galaxy Tab 4 Beta mode
T142976 Samsung Galaxy Tab 4 Beta Mode.png (1×800 px, 158 KB)

iPad Air 2 (iOS 10.2) stable
T142976 iPad Air 2 (iOS 10.2).PNG (2×1 px, 266 KB)

iPad Air 2 (iOS 10.2) Beta mode
T142976 iPad Air 2 (iOS 10.2) Beta Mode.PNG (2×1 px, 266 KB)

Thus, this issue appears to be fixed.

Nicholas.tsg moved this task from Needs QA to Ready for Signoff on the Reading-Web-Sprint-86-🔪🦃 board.Nov 27 2016, 9:21 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 27 2016, 11:01 PM
ovasileva closed this task as Resolved.Nov 28 2016, 11:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits