| Jdlrobson | |
| Oct 18 2016, 11:30 PM |
| F4884754: Screen Shot 2016-11-29 at 13.34.39.png | |
| Nov 29 2016, 6:35 PM |
| F4634283: Screen Shot 2016-10-20 at 10.51.01 AM.png | |
| Oct 20 2016, 5:52 PM |
| F4634286: Screen Shot 2016-10-20 at 10.17.05 AM.png | |
| Oct 20 2016, 5:52 PM |
| F4623984: Screen Shot 2016-10-18 at 4.29.06 PM.png | |
| Oct 18 2016, 11:30 PM |
As a user who has never added anything to my watchlist
When I click on the watchlist link in the main menu
I see a confusing blank screen like so:
(Test this by visiting a wiki you have never used)
We have some code in SpecialMobileWatchlist that used to deal with this.
SpecialMobileWatchlist::showEmptyList
We should fix it and add a browser test.
Ignoring the list/modified tabs, it should look like this:
List viw:
Feed view:
Change 323337 had a related patch set uploaded (by Jdlrobson):
Fix empty watchlist views
Tested on https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:EditWatchlist after removing all of my watched pages:
The associated browser tests are still failing consistently, e.g. https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/249/testReport/junit/(root)/Manage%20Watchlist/Empty_Watchlist_on_feed_view/.
Change 325321 had a related patch set uploaded (by Jdlrobson):
Logged in user tests do not work on beta cluster
It seems the step "I am logged in as a new user" is not working on labs. You can see in the screenshot the user has been making edits. I guess the beta cluster uses the same user for everything unlike the per commit runs? cc @zeljkofilipin
With that in mind it's probably worth disabling this test on the beta cluster for the time being...
Change 325321 merged by jenkins-bot:
Logged in user tests do not work on beta cluster
@bmansurov I think you can create out a task in the release engineering team backlog that it's not possible to do these sort of tests on the cluster and that we need a reliable way to do test code paths for new users. The issue is in the Ruby mediawiki_api module/integration config not MobileFrontend.
Given this test will run on @integration I wouldn't be too concerned that it's omitted in this build.
New build triggered: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/251/