Create Task
Maniphest T150556

[Regression pre-wmf.3] Cursor jumps to the beginning of the article after adding Citation/Media/Template/Formula/Graph
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Add a Citation/Media/Template/Formula/Graph anywhere in the page with VE

Observed Result:
Cursor jumps to the beginning of the article as soon as I add these nodes

Details

SubjectRepoBranchLines +/-
Follow-up Iaa7dffc13: *Actually* allow $returnFocusTo to be nulloojs/uimaster+1 -1
WindowManager: Allow $returnFocusTo to be nulloojs/uimaster+5 -2
Update VE core submodule to wmf/1.29.0-wmf.3 HEAD (01fc399)mediawiki/extensions/VisualEditorwmf/1.29.0-wmf.3+1 -1
Update VE core submodule to master (83ea152)mediawiki/extensions/VisualEditormaster+1 -1
Update VE core submodule to wmf/1.29.0-wmf.3 HEAD (01fc399)mediawiki/extensions/VisualEditormaster+1 -1
Make $returnFocusTo a no-op in WindowManagerVisualEditor/VisualEditorwmf/1.29.0-wmf.3+12 -6
Make $returnFocusTo a no-op in WindowManagerVisualEditor/VisualEditormaster+12 -6
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Nov 11 2016, 11:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2016, 11:06 PM
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.Nov 14 2016, 7:10 PM
Jdforrester-WMF triaged this task as High priority.Nov 15 2016, 5:47 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
Jdforrester-WMF added subscribers: DLynch, • Esanders.
gerritbot subscribed.Nov 16 2016, 7:16 PM

Change 321915 had a related patch set uploaded (by Esanders):
Make $returnFocusTo a no-op in WindowManager

https://gerrit.wikimedia.org/r/321915

gerritbot added a project: Patch-For-Review.Nov 16 2016, 7:16 PM
gerritbot added a comment.Nov 16 2016, 7:32 PM

Change 321917 had a related patch set uploaded (by Esanders):
WindowManager: Allow $returnFocusTo to be null and make it the default

https://gerrit.wikimedia.org/r/321917

• Esanders raised the priority of this task from High to Unbreak Now!.Nov 16 2016, 9:27 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptNov 16 2016, 9:27 PM
gerritbot added a comment.Nov 16 2016, 10:18 PM

Change 321915 merged by jenkins-bot:
Make $returnFocusTo a no-op in WindowManager

https://gerrit.wikimedia.org/r/321915

gerritbot added a comment.Nov 16 2016, 10:19 PM

Change 321994 had a related patch set uploaded (by Jforrester):
Make $returnFocusTo a no-op in WindowManager

https://gerrit.wikimedia.org/r/321994

gerritbot added a comment.Nov 16 2016, 10:19 PM

Change 321995 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (83ea152)

https://gerrit.wikimedia.org/r/321995

gerritbot added a comment.Nov 16 2016, 10:25 PM

Change 321994 merged by jenkins-bot:
Make $returnFocusTo a no-op in WindowManager

https://gerrit.wikimedia.org/r/321994

gerritbot added a comment.Nov 16 2016, 10:28 PM

Change 321999 had a related patch set uploaded (by Jforrester):
Update VE core submodule to wmf/1.29.0-wmf.3 HEAD (rGVED01fc399e9662)

https://gerrit.wikimedia.org/r/321999

gerritbot added a comment.Nov 16 2016, 10:34 PM

Change 322001 had a related patch set uploaded (by Jforrester):
Update VE core submodule to wmf/1.29.0-wmf.3 HEAD (rGVED01fc399e9662)

https://gerrit.wikimedia.org/r/322001

gerritbot added a comment.Nov 16 2016, 10:35 PM

Change 321999 abandoned by Jforrester:
Update VE core submodule to wmf/1.29.0-wmf.3 HEAD (rGVED01fc399e9662)

Reason:
Meh.

https://gerrit.wikimedia.org/r/321999

gerritbot added a comment.Nov 17 2016, 12:29 AM

Change 321995 merged by jenkins-bot:
Update VE core submodule to master (83ea152)

https://gerrit.wikimedia.org/r/321995

gerritbot added a comment.Nov 17 2016, 12:38 AM

Change 322001 merged by jenkins-bot:
Update VE core submodule to wmf/1.29.0-wmf.3 HEAD (rGVED01fc399e9662)

https://gerrit.wikimedia.org/r/322001

Stashbot subscribed.Nov 17 2016, 12:53 AM

Mentioned in SAL (#wikimedia-operations) [2016-11-17T00:53:24Z] <dereckson@tin> Synchronized php-1.29.0-wmf.3/extensions/VisualEditor/lib/ve/src/ui/: Make $returnFocusTo a no-op in WindowManager (T150556) (duration: 00m 49s)

Jdforrester-WMF closed this task as Resolved.Nov 17 2016, 12:56 AM
Jdforrester-WMF assigned this task to • Esanders.
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)), OOUI, MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)); removed Patch-For-Review.
Ryasmeen added a project: Verified.Nov 17 2016, 9:11 PM
Krinkle awarded a token.Nov 18 2016, 11:31 PM
Krinkle subscribed.
gerritbot added a comment.Nov 22 2016, 10:56 PM

Change 321917 merged by jenkins-bot:
WindowManager: Allow $returnFocusTo to be null

https://gerrit.wikimedia.org/r/321917

gerritbot added a comment.Mar 16 2017, 11:10 AM

Change 343028 had a related patch set uploaded (by Esanders):
[oojs/ui] Follow-up Iaa7dffc13: *Actually* allow $returnFocusTo to be null

https://gerrit.wikimedia.org/r/343028

Restricted Application edited projects, added User-Ryasmeen; removed MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)). · View Herald TranscriptMar 16 2017, 11:10 AM
gerritbot added a project: Patch-For-Review.Mar 16 2017, 11:10 AM
gerritbot added a comment.Mar 16 2017, 3:25 PM

Change 343028 merged by jenkins-bot:
[oojs/ui] Follow-up Iaa7dffc13: *Actually* allow $returnFocusTo to be null

https://gerrit.wikimedia.org/r/343028

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Apr 13 2017, 12:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits