https://gerrit.wikimedia.org/r/#/c/321097/ contains a change that only changes some text in the unit test descriptions. Still, the QUnit run fails. Continuous integration tests should work for submitted code.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix broken tests | mediawiki/extensions/MultimediaViewer | REL1_28 | +15 -12 | |
| Fix broken tests | mediawiki/extensions/MultimediaViewer | master | +15 -12 |
Related Objects
Related Objects
Event Timeline
Comment Actions
That is the QUnit tests that are failing most probably due to a breaking change in MediaWiki. It should be quite easy to reproduce.
Looking at https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/MultimediaViewer
https://gerrit.wikimedia.org/r/#/c/316706/ passed on October 19th
https://gerrit.wikimedia.org/r/#/c/318066/ by @Gilles failed on October 26th.
- One can run the QUnit tests with MediaWiki core at both dates and see what happens then bisect and find out the commit that caused the regression.
- Maybe it is an issue with a new Chromium version
Comment Actions
@jhobs Would you please indicate what this task needs to get out of Needs Analysis? :)
Comment Actions
We're running some rechecks on the gerrit patches now. If Jenkins still reports failures, then we'll investigate if these can be reproduced locally. If Jenkins passes, then we should be able to decline this as a sporadic failure.
Comment Actions
Both CI rechecks failed with the same assertion error:
mmv.Config shouldShowStatusInfo FAILED Status info is not shown when MMV is enabled Expected: false Actual: true
Might be an issue with Chrome local storage or most probably an incompatible change in MediaWiki core.
Comment Actions
Change 319478 had a related patch set uploaded (by Gergő Tisza):
[WIP] Fix broken test