Currently, if $wgCookieSetOnAutoblock is set to true and someone gets a block cookie set, but then $wgCookieSetOnAutoblock is set to false (and the user's cookie still exists), they will get a fatal error when they try to edit a page:
Fatal error: Call to a member function setCookie() on a non-object in /Users/kaldari/Sites/core/includes/user/User.php on line 1665
This is because it's trying to call setCookie() on $block (to clear it), but $block isn't an instantiated object in this case.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Prevent fatal error if $wgCookieSetOnAutoblock is changed to false | mediawiki/core | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • TBolliger | T120734 Epic ⚡️ Improve MediaWiki's blocking tools | |||
| Resolved | MusikAnimal | T5233 Send a cookie with each block | |||
| Resolved | kaldari | T151097 Switching $wgCookieSetOnAutoblock from true to false can cause fatal error |
Change 322377 had a related patch set uploaded (by Kaldari):
Prevent fatal error if $wgCookieSetOnAutoblock is changed to false
Change 322377 merged by jenkins-bot:
Prevent fatal error if $wgCookieSetOnAutoblock is changed to false