Create Task
Maniphest T151868

Template translation is broken if none of the parameters can be auto-mapped
Closed, ResolvedPublic
Actions

Description

I'm trying to translate the article אייל קרים ("Eyal Krim") from Hebrew to English.

It has infobox חייל ("hayal") in the beginning. Its English equivalent template is Infobox military person.

When I try to translated, I see that the template card says "חייל". I would expect it to say the English name.

I cannot edit it either. I clicked the empty paragraph several times and nothing happened.

The current version according Special:Version is rECTXcfaf2a4ad82f86ce057b0af4f2721f88428f255d.

I tried it with several more articles: "Hoboken, New Jersey", "Olivia Newton-John", "Whale shark". Broken everywhere.

"Unbreak now" because we are branching today, and we may deploy broken template adaptation.

Details

SubjectRepoBranchLines +/-
Allow template editor even if parameter mapping fails completelymediawiki/extensions/ContentTranslationwmf/1.29.0-wmf.4+1 -1
Allow template editor even if parameter mapping fails completelymediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Nov 29 2016, 12:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2016, 12:02 PM
Amire80 renamed this task from Template {{Infobox military person}} cannot be translated in CX2 to Template translation is broken in CX2.Nov 29 2016, 12:14 PM
Amire80 triaged this task as Unbreak Now! priority.
Amire80 updated the task description. (Show Details)
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptNov 29 2016, 12:14 PM
Amire80 added a project: Language-Q2-2016-17 Sprint 4.Nov 29 2016, 12:18 PM
Restricted Application added a project: Language-Engineering October-December 2016. · View Herald TranscriptNov 29 2016, 12:18 PM
Amire80 renamed this task from Template translation is broken in CX2 to Template translation to Hebrew is broken in CX2.Nov 29 2016, 12:24 PM
Arrbee lowered the priority of this task from Unbreak Now! to High.Nov 29 2016, 12:49 PM
Arrbee subscribed.

Lowering the priority because this is not in production yet.

gerritbot subscribed.Nov 29 2016, 1:22 PM

Change 324173 had a related patch set uploaded (by Nikerabbit):
Allow template editor even if parameter mapping fails completely

https://gerrit.wikimedia.org/r/324173

gerritbot added a project: Patch-For-Review.Nov 29 2016, 1:22 PM
KartikMistry subscribed.Nov 29 2016, 2:36 PM
Amire80 renamed this task from Template translation to Hebrew is broken in CX2 to Template translation is broken if none of the parameters can be auto-mapped.Nov 29 2016, 6:30 PM

Just a summary:

Niklas found that this only happens when none of the parameters can be auto-mapped in any way. Of course, in such a case it must still be possible to select the parameters and to type their values manually.

Amire80 moved this task from Needs Triage to Oct.-Dec. 2016 on the ContentTranslation board.Nov 29 2016, 6:32 PM
santhosh subscribed.Nov 30 2016, 3:43 AM

Right. this is case we need change in this iteration. Before the template editor, we were aborting the adaptation process when none of parameters were able to map. Now we can allow the adaptation process to proceed

santhosh added a comment.Nov 30 2016, 4:20 AM

Screenshot with the above patch

pasted_file (735×1 px, 251 KB)

gerritbot added a comment.Nov 30 2016, 4:30 AM

Change 324173 merged by jenkins-bot:
Allow template editor even if parameter mapping fails completely

https://gerrit.wikimedia.org/r/324173

gerritbot added a comment.Nov 30 2016, 4:34 AM

Change 324377 had a related patch set uploaded (by KartikMistry):
Allow template editor even if parameter mapping fails completely

https://gerrit.wikimedia.org/r/324377

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Nov 30 2016, 5:00 AM
santhosh moved this task from Backlog to In Review on the Language-Q2-2016-17 Sprint 4 board.Nov 30 2016, 6:55 AM
Arrbee added a project: Unplanned-Sprint-Work.Nov 30 2016, 6:59 AM
gerritbot added a comment.Nov 30 2016, 2:32 PM

Change 324377 merged by jenkins-bot:
Allow template editor even if parameter mapping fails completely

https://gerrit.wikimedia.org/r/324377

Stashbot subscribed.Nov 30 2016, 2:40 PM

Mentioned in SAL (#wikimedia-operations) [2016-11-30T14:40:01Z] <dereckson@tin> Synchronized php-1.29.0-wmf.4/extensions/ContentTranslation/modules/tools/ext.cx.tools.template.js: Allow template editor even if parameter mapping fails completely (T151868) (duration: 00m 45s)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 30 2016, 3:00 PM
KartikMistry moved this task from In Review to QA on the Language-Q2-2016-17 Sprint 4 board.Dec 1 2016, 5:20 AM
Amire80 moved this task from QA to Blocked on the Language-Q2-2016-17 Sprint 4 board.Dec 5 2016, 6:29 PM
Amire80 moved this task from Blocked to Done on the Language-Q2-2016-17 Sprint 4 board.
Arrbee closed this task as Resolved.Dec 6 2016, 6:47 AM
Arrbee claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits