⚓ T177801 Collection phpunit tests are failing for table of contents when run locally

Subject	Repo	Branch	Lines +/-
Stop testing render side effects	mediawiki/extensions/Collection	master	+14 -24
Update test mock to return license info	mediawiki/extensions/Collection	master	+24 -3
Update test HTML hierarchy	mediawiki/extensions/Collection	master	+20 -10
Deal with cases where contributors and images are not defined	mediawiki/extensions/Collection	master	+10 -3

Status	Assigned	Task
Resolved	• JKatzWMF	T150871 [EPIC] (Proposal) Replicate core OCG features and sunset OCG service
Invalid	None	T186740 [EPIC] It should be possible to print a book using the Proton service
Stalled	None	T174670 Remove banner from saved books
Invalid	None	T171832 Deploy new book renderer to all projects
Duplicate	None	T171833 Deploy new book renderer to all projects side by side with OCG
Declined	None	T173018 Add an option in Special:Book to download PDFs generated by ElectronPdfService
Invalid	None	T173015 Use PDF post-processing service to generate final PDF
Invalid	None	T173579 Expose PDF post-processing scripts as a stateless web service
Resolved	• bmansurov	T171965 [Spike - 8 hours] How should the PDF post-processing script be exposed for use by Extension:Collection
Resolved	pmiazga	T171838 Build out article concatenation according to requirements for books
Resolved	ovasileva	T175856 Implement changes to article concatenation based on books requirements
Resolved	phuedx	T177672 Collection tests do not run properly
Resolved	phuedx	T177801 Collection phpunit tests are failing for table of contents when run locally
Resolved	• dpatrick	T173014 Security review of pdfrw

Jdlrobson created this task.Oct 9 2017, 8:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2017, 8:56 PM

Change 383250 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@master] Deal with cases where contributors and images are not defined

https://gerrit.wikimedia.org/r/383250

gerritbot added a project: Patch-For-Review.Oct 9 2017, 8:59 PM

Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 9 2017, 8:59 PM

Change 383285 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@master] Update test HTML hierarchy

https://gerrit.wikimedia.org/r/383285

Change 383286 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@master] Update test mock to return license info

https://gerrit.wikimedia.org/r/383286

Change 383287 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@master] Stop testing chapter generation in templates

https://gerrit.wikimedia.org/r/383287

Jdlrobson renamed this task from Collection phpunit tests fail when run locally to Collection phpunit tests are failing for table of contents when run locally.Oct 9 2017, 10:28 PM

Jdlrobson updated the task description. (Show Details)

Change 383250 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Deal with cases where contributors and images are not defined

https://gerrit.wikimedia.org/r/383250

Change 383285 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Update test HTML hierarchy

https://gerrit.wikimedia.org/r/383285

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 10 2017, 12:00 AM

https://gerrit.wikimedia.org/r/383287 and https://gerrit.wikimedia.org/r/383286 will get the tests passing again. I'm working on tests for the uncovered functionality - TOC generation.

Is this blocked by T177672: Collection tests do not run properly?

Actually, @Jdlrobson, I'll base rECOL89f7386e303f: Register PHPUnit tests via UnitTestsList hook off of your changes.

phuedx assigned this task to Jdlrobson.Oct 10 2017, 1:19 PM

phuedx mentioned this in T177672: Collection tests do not run properly.Oct 10 2017, 1:43 PM

Change 383286 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Update test mock to return license info

https://gerrit.wikimedia.org/r/383286

phuedx added a parent task: T177672: Collection tests do not run properly.Oct 10 2017, 5:10 PM

https://gerrit.wikimedia.org/r/#/c/383287/ still needs review. This will unblock several tasks in blocked.

MBinder_WMF triaged this task as High priority.Oct 10 2017, 5:13 PM

MBinder_WMF added projects: Web-Team-Backlog, Collection, Proton.

Change 383287 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Stop testing render side effects

https://gerrit.wikimedia.org/r/383287

All of the associated changes have been merged.

phuedx moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Oct 10 2017, 5:51 PM

This is a purely technical task. QA has been done as part of code review (and it mostly came down to checking whether or not the tests enabled in T177672: Collection tests do not run properly were passing).

phuedx removed Jdlrobson as the assignee of this task.Oct 10 2017, 6:03 PM

Jdlrobson moved this task from Incoming to 2017-18 Q2 on the Web-Team-Backlog board.Oct 10 2017, 9:19 PM

Being bold. The tests are passing. Thanks, @Jdlrobson! 🎉🎉🎉

Collection phpunit tests are failing for table of contents when run locally
Closed, ResolvedPublic
Actions

Description

Acceptance criteria

Details

Related Objects
Search...

Event Timeline

Collection phpunit tests are failing for table of contents when run locallyClosed, ResolvedPublicActions