Maniphest T198811

Convert UNIQUE indexes to Primary Keys in MW Core Tables
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Jul 4 2018, 6:56 PM

Description

Forked from https://discourse-mediawiki.wmflabs.org/t/database-structure-change-for-use-in-mysql-cluster/595 as a follow on from T17441 and T164399

Although these tables do have UNIQUE indexes, they don't have primary keys.

interwiki
page_props
protected_titles
site_identifiers

Details

Subject	Repo	Branch	Lines +/-
Migrate l10n_cache and module_deps to abstract schema	mediawiki/core	master	+100 -38
Migrate user_properties to abstract schema	mediawiki/core	master	+57 -33
Convert numerous UNIQUE INDEX to PRIMARY KEY	mediawiki/core	master	+159 -26

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	LSobanski	T17441 Some tables lack unique or primary keys, may allow confusing duplicate data
Resolved	Reedy	T198811 Convert UNIQUE indexes to Primary Keys in MW Core Tables
		· · ·

Event Timeline

Reedy created this task.Jul 4 2018, 6:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2018, 6:56 PM

Reedy added a parent task: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.Jul 4 2018, 6:57 PM

Reedy updated the task description. (Show Details)Jul 4 2018, 7:03 PM

Change 443858 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] [WIP] Convert UNIQUE INDEX to PRIMARY KEY

https://gerrit.wikimedia.org/r/443858

gerritbot added a project: Patch-For-Review.Jul 4 2018, 7:14 PM

Change 443858 merged by jenkins-bot:
[mediawiki/core@master] Convert numerous UNIQUE INDEX to PRIMARY KEY

https://gerrit.wikimedia.org/r/443858

Reedy closed this task as Resolved.Jul 11 2018, 7:58 PM

Reedy claimed this task.

Reedy removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)).Jul 11 2018, 8:00 PM

Reedy mentioned this in T199368: Convert UNIQUE INDEX to PK in Production.Jul 11 2018, 8:01 PM

Change 617565 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Migrate user_properties to abstract schema

https://gerrit.wikimedia.org/r/617565

gerritbot added a project: Patch-For-Review.Jul 31 2020, 12:45 AM

Change 617565 merged by jenkins-bot:
[mediawiki/core@master] Migrate user_properties to abstract schema

https://gerrit.wikimedia.org/r/617565

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2020, 8:10 PM

Change 618409 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Migrate l10n_cache and module_deps to abstract schema

https://gerrit.wikimedia.org/r/618409

gerritbot added a project: Patch-For-Review.Aug 4 2020, 11:07 PM

Change 618409 merged by jenkins-bot:
[mediawiki/core@master] Migrate l10n_cache and module_deps to abstract schema

https://gerrit.wikimedia.org/r/618409

Maintenance_bot removed a project: Patch-For-Review.Aug 9 2020, 3:10 PM