Maniphest T203427

<maplink> behavior completely destroyed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RolandUnger
	Sep 4 2018, 6:17 AM

Description

With the last deployment, the behavior of <maplink> links was completely changed and is not working any longer.

The link is no link any longer. Anybody added the following stylsheet lines:

.client-js .mw-kartographer-maplink:not(.mw-kartographer-link):not(.ve-ce-focusableNode), .client-js .mw-kartographer-map:not(.mw-kartographer-link):not(.mw-kartographer-interactive) {
	pointer-events: none;
	cursor: default;
}

which means that the marker links are not working as links.

The link href does not links to a map but to a special page like https://en.wikivoyage.org//wiki/Special:Map/17/30.11914/31.40073/en. That means that no real map is shown presenting all the markers given in the article.

Details

Subject	Repo	Branch	Lines +/-
Restoring maplink behavior	mediawiki/extensions/Kartographer	wmf/1.32.0-wmf.19	+47 -2
Restoring maplink behavior	mediawiki/extensions/Kartographer	wmf/1.32.0-wmf.20	+47 -2
Restoring maplink behavior	mediawiki/extensions/Kartographer	master	+47 -2

Customize query in gerrit

Related Objects

Mentioned Here: T221439: Static mapframe not clickable in 1.34.0-wmf.1
T221781: Mapframe map thumbnails are unclickable, and full screen map cannot be loaded

Event Timeline

RolandUnger created this task.Sep 4 2018, 6:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2018, 6:17 AM

Confirming (removing pointer-events: none; cursor: default; makes the links clickable again).

Just to make sure it's fixed everywhere: same problem on frwiki.

Gareth subscribed.Sep 4 2018, 6:02 PM

Framawiki renamed this task from <maplink> behavior completely destroyed at Wikivoyage to <maplink> behavior completely destroyed.Sep 4 2018, 6:52 PM

Framawiki subscribed.

Unless I misunderstand something, maps overall just became non-interactive: if you remove that CSS, with JS active it shouldn’t go to Special:Maps/…, it should display the map in its own modal. The issue is not in having CSS that prevents maps from being interactive before JS does its job, the issue is that JS for maps stopped loading or working.

MSantos subscribed.Sep 5 2018, 3:16 PM

MSantos claimed this task.Sep 5 2018, 4:10 PM

MSantos added projects: Product-Infrastructure-Team-Backlog-Deprecated, Maps-Sprint.

Change 458206 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/Kartographer@master] Restoring maplink behavior

https://gerrit.wikimedia.org/r/458206

gerritbot added a project: Patch-For-Review.Sep 5 2018, 4:14 PM

MSantos edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.Sep 5 2018, 4:17 PM

MSantos moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 5 2018, 4:44 PM

MSantos moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 5 2018, 4:51 PM

Change 458206 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Restoring maplink behavior

https://gerrit.wikimedia.org/r/458206

MSantos moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 5 2018, 5:17 PM

Change 458217 had a related patch set uploaded (by Krinkle; owner: MSantos):
[mediawiki/extensions/Kartographer@wmf/1.32.0-wmf.20] Restoring maplink behavior

https://gerrit.wikimedia.org/r/458217

Change 458222 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/Kartographer@wmf/1.32.0-wmf.19] Restoring maplink behavior

https://gerrit.wikimedia.org/r/458222

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 5 2018, 6:00 PM

CKoerner_WMF merged a task: T203590: maplink no longer generates the link.Sep 5 2018, 6:30 PM

CKoerner_WMF added subscribers: Atsirlin, Ymblanter, CKoerner_WMF.

Making a note of the conversation where this is being discussed on English Wikivoyage.

https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#POP-UP_maps_for_markers/listings

Fixed in master (and thus on Beta Cluster, see https://en.wikipedia.beta.wmflabs.org/wiki/MapLink. Will deploy as soon as the production deployment seat is available.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptSep 5 2018, 6:44 PM

MSantos moved this task from Backlog to Done on the Maps-Sprint board.Sep 5 2018, 6:47 PM

Change 458217 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@wmf/1.32.0-wmf.20] Restoring maplink behavior

https://gerrit.wikimedia.org/r/458217

Change 458222 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@wmf/1.32.0-wmf.19] Restoring maplink behavior

https://gerrit.wikimedia.org/r/458222

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)); removed MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 5 2018, 8:00 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-05T20:14:12Z] <krinkle@deploy1001> Synchronized php-1.32.0-wmf.20/extensions/Kartographer/: Ie5744d45b - T203427 (duration: 00m 58s)

Mentioned in SAL (#wikimedia-operations) [2018-09-05T20:17:57Z] <krinkle@deploy1001> Synchronized php-1.32.0-wmf.19/extensions/Kartographer/: Ie5744d45b - T203427 (duration: 00m 57s)