Deploy core version of watchlist for AMC users
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	Oct 14 2019, 9:44 AM

Description

NOTE: deployment date: Monday, Oct 28, 2019

Background

In T225127: Display core version of watchlist page for AMC users we made changes to the core watchlist page on mobile so that we can display it to AMC users. Now we're ready to deploy

Acceptance criteria

A SWAT deploy has enabled the core version of watchlist page to all AMC users (on all projects)

QA steps

on mobile, with AMC turned on, go to watchlist page
new version of watchlist should appear

Developer notes

$wgMFUseDesktopSpecialWatchlistPage is the flag to use.

Details

	Subject	Repo	Branch	Lines +/-
	Enable the desktop Special:Watchlist on AMC mode	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Goal	ovasileva	T198313 [GOAL] Advanced mobile contributions
Resolved		ovasileva	T228916 Deploy AMC to all Wikipedias
Resolved		ovasileva	T223922 [EPIC] Display core version of recent changes page for AMC users
Open		None	T229360 [Tracking/Epic] Problems with RecentChanges and Watchlist advanced mobile contribution experience
Resolved		ovasileva	T235414 Deploy core version of watchlist for AMC users
Resolved		ovasileva	T225127 Display core version of watchlist page for AMC users
Invalid		None	T235534 [AMC] fix alignment of "Edit your list of watched pages
Resolved		ovasileva	T235535 [AMC] fix alignment of "Edit your list of watched pages" button on AMC watchlist page
Resolved		ovasileva	T235536 [AMC] fix alignment of "Saved filters" button on AMC watchlist page

Event Timeline

ovasileva created this task.Oct 14 2019, 9:44 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 14 2019, 9:44 AM

ovasileva triaged this task as High priority.Oct 14 2019, 9:44 AM

ovasileva added a subtask: T225127: Display core version of watchlist page for AMC users.

Masumrezarock100 added a project: Advanced Mobile Contributions.Oct 14 2019, 6:06 PM

looks like the config needed here is $wgMFUseDesktopSpecialWatchlistPage. I think this is ready to be estimated?

Jdlrobson added a project: Wikimedia-Site-requests.Oct 15 2019, 4:04 PM

Restricted Application added a subscriber: Dereckson. · View Herald TranscriptOct 15 2019, 4:04 PM

Jdlrobson updated the task description. (Show Details)Oct 15 2019, 4:05 PM

ovasileva set the point value for this task to 2.Oct 15 2019, 4:06 PM

Jdlrobson added a parent task: T229360: [Tracking/Epic] Problems with RecentChanges and Watchlist advanced mobile contribution experience.Oct 15 2019, 7:16 PM

ovasileva closed subtask T225127: Display core version of watchlist page for AMC users as Resolved.Oct 24 2019, 9:13 AM

ovasileva mentioned this in T225127: Display core version of watchlist page for AMC users.

ovasileva moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.

ovasileva updated the task description. (Show Details)

Looks all good! @Johan Should we add this announcement to the next Tech news?

Masumrezarock100 moved this task from Backlog to To deploy on the Wikimedia-Site-requests board.Oct 24 2019, 9:37 AM

ovasileva added a project: User-notice.Oct 24 2019, 9:39 AM

Johan moved this task from To Triage to Announce in next Tech/News on the User-notice board.Oct 24 2019, 10:54 AM

Johan removed a project: User-notice.

ovasileva moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 28 2019, 5:12 PM

Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 28 2019, 5:15 PM

Change 546656 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Enable the desktop Special:Watchlist on AMC mode

https://gerrit.wikimedia.org/r/546656

gerritbot added a project: Patch-For-Review.Oct 28 2019, 5:15 PM

Jdlrobson assigned this task to Jdrewniak.Oct 28 2019, 5:15 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.

Change 546656 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Enable the desktop Special:Watchlist on AMC mode

https://gerrit.wikimedia.org/r/546656

Maintenance_bot removed a project: Patch-For-Review.Oct 28 2019, 7:10 PM

@ovasileva this will ride the train. Available in AMC on Wednesday to mediawiki.org and all wikipedias Thursday (provided all goes to plan). Not sure how you want to deal with QA.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 28 2019, 8:00 PM

Deployment date is Monday. But I am still seeing the MobileFrontend version of Watchlist.

In T235414#5614171, @Masumrezarock100 wrote:

Deployment date is Monday. But I am still seeing the MobileFrontend version of Watchlist.

@Masumrezarock100 - see T235414#5613072 - we've decided to let it ride the train, meaning it will be available everywhere by Thursday this week.

In T235414#5613072, @Jdlrobson wrote:

@ovasileva this will ride the train. Available in AMC on Wednesday to mediawiki.org and all wikipedias Thursday (provided all goes to plan). Not sure how you want to deal with QA.

Let's QA on Thursday

ovasileva moved this task from Ready for Signoff to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 29 2019, 5:55 PM

Looks good to me. But the trailing semicolon after an username is kinda annoying.

In T235414#5625318, @Masumrezarock100 wrote:

Looks good to me. But the trailing semicolon after an username is kinda annoying.

Patches welcomed :) https://phabricator.wikimedia.org/T233649

After this change, my watchlist is more than double the width of my screen! Apparently neither the size of the buttons nor the length of edit summaries can fit the screen size. Should I open a new task for that? It needs to be fixed asap, the watchlist is barely usable like this.

BF816B32-2BB8-4818-B36F-1711A45039C1.png (1×640 px, 89 KB)

@XanonymusX - what browser/device are you on?

@Edtadros - tested on Chrome/Android and it looks great, but seems like we might have a problem with iOS based on T235414#5626146. Could you take a look on a couple of iOS devices?

@ovasileva I think I know what the problem is. Large edit summaries are not fitting in the screen properly. I was able to reproduce the same on my Android/Chrome Dev 79.

Screenshot_20191101-174912.png (960×480 px, 84 KB)

Screenshot_20191101-174844.png (960×480 px, 96 KB)

And this is happening with other Special pages not just Special:Watchlist.

Yeah, in my case there were some very long web links in summaries. But even if I get rid of those, the initial buttons are still way too large (at least in German) for the screen size. I’m using iOS and testing it now on the smallest screen possible (I guess), on the iPod touch.

4E4E88F5-8942-4B97-9129-E5927270CEF9.png (1×640 px, 107 KB)

EDIT: Btw, the width problem occurs also on several other pages like the notifications page, so I guess this is a general issue with advanced mobile now?! Please do something about it asap.

Masumrezarock100 mentioned this in T237204: Make the new design of mobile watchlist opt-in.Nov 3 2019, 8:28 PM

In T235414#5626403, @XanonymusX wrote:

EDIT: Btw, the width problem occurs also on several other pages like the notifications page, so I guess this is a general issue with advanced mobile now?! Please do something about it asap.

I am not so sure about the notification page, but definitely other Special pages are affected by this. Original MobileFrontend pages start long edit summaries and texts in a new line, while core counterparts don't.

Thanks @XanonymusX and @Masumrezarock100 - opened T237230 to track this. Resolving this task for now.

ovasileva updated the task description. (Show Details)Nov 4 2019, 9:57 AM

XanonymusX mentioned this in T237244: OOUI buttons with large labels breaks width of several special pages in mobile view.Nov 4 2019, 11:22 AM

MNeisler mentioned this in T237750: Investigate user behavior on the new AMC Watchlist page.Jan 3 2020, 5:06 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-11T19:02:37Z] <catrope@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Add *.bollywoodhungama.in and *.britishmuseum.org to $wgCopyUploadDomains (T235414, T251882) (duration: 00m 57s)

Mentioned in SAL (#wikimedia-operations) [2020-05-11T19:03:24Z] <Zoranzoki21> T235414 is wrong task number, T235415 is correct

Stashbot mentioned this in T235415: Copy uploads not working for https://www.bollywoodhungama.com.May 11 2020, 7:03 PM

	F30945780: 4E4E88F5-8942-4B97-9129-E5927270CEF9.png
	Nov 1 2019, 1:11 PM

	F30945732: Screenshot_20191101-174844.png
	Nov 1 2019, 12:24 PM

	F30945728: Screenshot_20191101-174912.png
	Nov 1 2019, 12:24 PM

	F30945652: BF816B32-2BB8-4818-B36F-1711A45039C1.png
	Nov 1 2019, 11:03 AM

Deploy core version of watchlist for AMC usersClosed, ResolvedPublic2 Estimated Story PointsActions