Create Task
Maniphest T236812

Parser.php should be split into a base class and a parser implementation
Open, Needs TriagePublic
Actions

Description

A number of the methods in Parser.php are helper methods, or getters/setters for common parser state. These should be moved to a base class (which will keep the Parser.php name), and actual implementation of the parse (the handle* functions) should be moved to a subclass, LegacyParser.php. The factory should be changed to create a LegacyParser by default.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Oct 29 2019, 4:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2019, 4:18 PM
cscott added a parent task: T236811: Parser creation should always use factory.Oct 29 2019, 4:18 PM
• ssastry edited projects, added Parsoid; removed Parsoid-PHP.Nov 5 2019, 5:53 PM
• ssastry removed a subscriber: Parsing-Team--ARCHIVED.
Jdforrester-WMF subscribed.Nov 5 2019, 11:02 PM
LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 15 2020, 12:05 AM
LGoto moved this task from Backlog to Non-Parsing-Team Tasks on the Parsoid board.Feb 21 2020, 5:26 PM
cscott edited parent tasks, added: T236809: Refactor Parser.php to allow alternate parser (Parsoid); removed: T236811: Parser creation should always use factory.Apr 16 2020, 10:21 PM
cscott added a subtask: T236811: Parser creation should always use factory.
cscott mentioned this in T240307: Hook container with strong types and DI.Jun 10 2020, 2:40 PM
xSavitar added a subtask: T258226: Introduce IParser interface with `getOutput()` method for implementation.Jul 16 2020, 10:30 PM
xSavitar closed this task as Invalid.Jul 16 2020, 10:34 PM
xSavitar added subscribers: Krinkle, xSavitar.
This comment was removed by xSavitar.
xSavitar reopened this task as Open.Jul 16 2020, 10:34 PM

Oops, closed the wrong ticket! Sorry!

xSavitar closed subtask T258226: Introduce IParser interface with `getOutput()` method for implementation as Invalid.Jul 16 2020, 10:35 PM
gerritbot added a comment.Aug 7 2020, 7:03 PM

Change 605687 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Clarify uses of legacy Parser objects

https://gerrit.wikimedia.org/r/605687

gerritbot added a project: Patch-For-Review.Aug 7 2020, 7:03 PM
gerritbot added a comment.Aug 18 2020, 4:38 AM

Change 605687 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Clarify uses of legacy Parser objects

https://gerrit.wikimedia.org/r/605687

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2020, 5:10 AM
gerritbot added a comment.Aug 24 2020, 5:34 PM

Change 622176 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a7

https://gerrit.wikimedia.org/r/622176

gerritbot added a project: Patch-For-Review.Aug 24 2020, 5:34 PM
gerritbot added a comment.Aug 24 2020, 10:16 PM

Change 622176 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to v0.13.0-a7

https://gerrit.wikimedia.org/r/622176

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2020, 11:10 PM
cscott mentioned this in T265518: Move Parsoid ServiceWorker.php and extension/src/Config into core.Oct 14 2020, 6:04 PM
MBinder_WMF edited projects, added Parsoid (Tracking); removed Parsoid.Dec 10 2020, 8:12 PM
cscott added a subtask: T275160: Make public properties of Parser private.Feb 18 2021, 8:48 PM
RobinHood70 subscribed.May 9 2021, 7:56 PM
RhinosF1 subscribed.Oct 24 2021, 12:09 PM
cscott mentioned this in T302118: Move MWParsoid\SiteConfig (and etc) to MediaWiki\Parser\Parsoid\SiteConfig (etc).Feb 18 2022, 10:25 PM
gerritbot added a comment.Sep 15 2022, 1:13 PM

Change 832494 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Make private deprecated public properties of Parser

https://gerrit.wikimedia.org/r/832494

gerritbot added a project: Patch-For-Review.Sep 15 2022, 1:13 PM
gerritbot added a comment.Sep 20 2022, 12:49 PM

Change 832494 merged by jenkins-bot:

[mediawiki/core@master] Make private deprecated public properties of Parser

https://gerrit.wikimedia.org/r/832494

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 20 2022, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 20 2022, 1:30 PM
TheresNoTime removed a subscriber: RhinosF1.Dec 15 2022, 11:36 PM
gerritbot added a comment.Feb 16 2024, 3:43 PM

Change 1004158 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $ot property

https://gerrit.wikimedia.org/r/1004158

gerritbot added a project: Patch-For-Review.Feb 16 2024, 3:43 PM
gerritbot added a comment.Feb 16 2024, 3:54 PM

Change 1004162 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mTitle property

https://gerrit.wikimedia.org/r/1004162

gerritbot added a comment.Feb 16 2024, 3:54 PM

Change 1004163 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mOptions property

https://gerrit.wikimedia.org/r/1004163

gerritbot added a comment.Apr 12 2024, 8:57 PM

Change #1019355 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal

https://gerrit.wikimedia.org/r/1019355

gerritbot added a comment.Apr 14 2024, 8:27 PM

Change #1004158 merged by jenkins-bot:

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $ot property

https://gerrit.wikimedia.org/r/1004158

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 14 2024, 9:00 PM
gerritbot added a comment.Apr 14 2024, 10:06 PM

Change #1004162 merged by jenkins-bot:

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mTitle property

https://gerrit.wikimedia.org/r/1004162

gerritbot added a comment.Apr 14 2024, 10:06 PM

Change #1004163 merged by jenkins-bot:

[mediawiki/core@master] [Parser] Emit warnings for accesses to deprecated $mOptions property

https://gerrit.wikimedia.org/r/1004163

gerritbot added a comment.Apr 14 2024, 10:28 PM

Change #1019355 merged by jenkins-bot:

[mediawiki/core@master] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal

https://gerrit.wikimedia.org/r/1019355

gerritbot added a comment.Apr 15 2024, 6:52 PM

Change #1019871 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $ot property

https://gerrit.wikimedia.org/r/1019871

gerritbot added a comment.Apr 15 2024, 6:52 PM

Change #1019872 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mTitle property

https://gerrit.wikimedia.org/r/1019872

gerritbot added a comment.Apr 15 2024, 6:52 PM

Change #1019873 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mOptions property

https://gerrit.wikimedia.org/r/1019873

gerritbot added a comment.Apr 15 2024, 6:52 PM

Change #1019874 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@REL1_42] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal

https://gerrit.wikimedia.org/r/1019874

gerritbot added a comment.Apr 16 2024, 1:21 PM

Change #1019871 merged by jenkins-bot:

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $ot property

https://gerrit.wikimedia.org/r/1019871

gerritbot added a comment.Apr 16 2024, 1:21 PM

Change #1019872 merged by jenkins-bot:

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mTitle property

https://gerrit.wikimedia.org/r/1019872

gerritbot added a comment.Apr 16 2024, 1:21 PM

Change #1019873 merged by jenkins-bot:

[mediawiki/core@REL1_42] [Parser] Emit warnings for accesses to deprecated $mOptions property

https://gerrit.wikimedia.org/r/1019873

gerritbot added a comment.Apr 16 2024, 1:21 PM

Change #1019874 merged by jenkins-bot:

[mediawiki/core@REL1_42] [Parser] Mark $mPPNodeCount and $mHighestExpansionDepth @internal

https://gerrit.wikimedia.org/r/1019874

ReleaseTaggerBot added a project: MW-1.42-notes.Apr 16 2024, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 6:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits