Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.
Closed, ResolvedPublic
Actions

Description

Seen on https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/41244/console testing maths...

13:57:42 1) PropertySuggester\ResultBuilderTest::testMergeWithTraditionalSearchResults
13:57:42 Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.
13:57:42 
13:57:42 2) PropertySuggester\ResultBuilderTest::testCreateResultsArray
13:57:42 Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.
13:57:42 
13:57:42 3) PropertySuggester\ResultBuilderTest::testValidCovers with data set #0 ('PropertySuggester\ResultBuilderTest', 'testMergeWithTraditionalSearchResults')
13:57:42 Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.
13:57:42 
13:57:42 4) PropertySuggester\ResultBuilderTest::testValidCovers with data set #1 ('PropertySuggester\ResultBuilderTest', 'testCreateResultsArray')
13:57:42 Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.
13:57:42 
13:57:42 5) PropertySuggester\ResultBuilderTest::testValidCovers with data set #2 ('PropertySuggester\ResultBuilderTest', 'testValidCovers')
13:57:42 Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.

Details

	Subject	Repo	Branch	Lines +/-
	Make phpunit:unit accept extension*.json to populate the classes	mediawiki/core	REL1_35	+12 -17
	Make phpunit:unit accept extension*.json to populate the classes	mediawiki/core	master	+12 -17

Customize query in gerrit

Event Timeline

Reedy created this task.Jan 18 2020, 2:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2020, 2:05 PM

Daimona added a project: MediaWiki-extensions-PropertySuggester.Jan 18 2020, 2:12 PM

Addshore moved this task from Incoming to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 20 2020, 9:35 AM

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 20 2020, 10:15 AM

Jakob_WMDE claimed this task.Jan 20 2020, 10:44 AM

Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

This is sorta expected, the class indeed exists but it's not registered through extension*.json system so the new unit tests can't pick it up (it's just "PHPUnit unit tests") and not the main tests. I recommend declining this. It's just a warning and it will be resolved once we fully move to PSR-4 and extension.json registration.

Jakob_WMDE removed Jakob_WMDE as the assignee of this task.Jan 20 2020, 11:36 AM

Jakob_WMDE subscribed.

Addshore edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jan 20 2020, 2:08 PM

Addshore moved this task from Incoming to Blocked / Waiting / External on the Wikidata-Campsite board.

We have fully moved to PSR-4 and extension.json registration, and the warning is still there. To reproduce locally:

user@host mediawiki $ vendor/bin/phpunit extensions/PropertySuggester/tests/phpunit/unit/ResultBuilderTest.php
PHPUnit 8.5.8 by Sebastian Bergmann and contributors.

WWW                                                                 3 / 3 (100%)

Time: 74 ms, Memory: 8.00 MB

There were 3 warnings:

1) PropertySuggester\ResultBuilderTest::testMergeWithTraditionalSearchResults
Cannot stub or mock class or interface "Wikibase\Lib\Store\EntityTitleLookup" which does not exist

2) PropertySuggester\ResultBuilderTest::testCreateResultsArray
Cannot stub or mock class or interface "Wikibase\Lib\Store\EntityTitleLookup" which does not exist

3) PropertySuggester\ResultBuilderTest::testValidCovers
Cannot stub or mock class or interface "Wikibase\Lib\Store\EntityTitleLookup" which does not exist

WARNINGS!
Tests: 3, Assertions: 0, Warnings: 3.

Isn’t the point that the tests in /unit/ are supposed to be independent of MediaWiki, and therefore it doesn’t matter what we register in extension.json, and the tests can only use libraries they get through composer? And EntityTitleLookup is in Wikibase, not any library.

In T243124#6368762, @Lucas_Werkmeister_WMDE wrote:

We have fully moved to PSR-4 and extension.json registration, and the warning is still there. To reproduce locally:

user@host mediawiki $ vendor/bin/phpunit extensions/PropertySuggester/tests/phpunit/unit/ResultBuilderTest.php
PHPUnit 8.5.8 by Sebastian Bergmann and contributors.

WWW                                                                 3 / 3 (100%)

Time: 74 ms, Memory: 8.00 MB

There were 3 warnings:

1) PropertySuggester\ResultBuilderTest::testMergeWithTraditionalSearchResults
Cannot stub or mock class or interface "Wikibase\Lib\Store\EntityTitleLookup" which does not exist

2) PropertySuggester\ResultBuilderTest::testCreateResultsArray
Cannot stub or mock class or interface "Wikibase\Lib\Store\EntityTitleLookup" which does not exist

3) PropertySuggester\ResultBuilderTest::testValidCovers
Cannot stub or mock class or interface "Wikibase\Lib\Store\EntityTitleLookup" which does not exist

WARNINGS!
Tests: 3, Assertions: 0, Warnings: 3.

Yes because the current mediawiki phpunit setup can't understand extension*.json (it only understands extension.json), we might be able to fix that easily though.

What I mean is this btw: https://github.com/wikimedia/mediawiki/blob/master/tests/phpunit/bootstrap.php#L78

Change 619004 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Make phpunit:unit accept extension*.json to populate the classes

https://gerrit.wikimedia.org/r/619004

gerritbot added a project: Patch-For-Review.Aug 7 2020, 3:48 PM

Ladsgroup claimed this task.Aug 7 2020, 4:33 PM

Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 7 2020, 4:34 PM

Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Aug 7 2020, 5:15 PM

Change 619004 merged by jenkins-bot:
[mediawiki/core@master] Make phpunit:unit accept extension*.json to populate the classes

https://gerrit.wikimedia.org/r/619004

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 10 2020, 4:27 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 10 2020, 5:00 PM

Addshore closed this task as Resolved.Aug 12 2020, 10:11 PM

Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Aug 12 2020, 10:15 PM

• amy_rc moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Mar 2 2021, 1:55 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2021, 2:11 PM

Change 693657 had a related patch set uploaded (by Reedy; author: Ladsgroup):

[mediawiki/core@REL1_35] Make phpunit:unit accept extension*.json to populate the classes

https://gerrit.wikimedia.org/r/693657

gerritbot added a project: Patch-For-Review.May 24 2021, 7:00 PM

Change 693657 merged by jenkins-bot:

[mediawiki/core@REL1_35] Make phpunit:unit accept extension*.json to populate the classes

https://gerrit.wikimedia.org/r/693657

ReleaseTaggerBot added a project: MW-1.35-notes.May 24 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 24 2021, 8:11 PM

Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.Closed, ResolvedPublicActions

Description

Details

Event Timeline

Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.
Closed, ResolvedPublic
Actions