Special:GlobalPreferences does not deal well with "conditional preferences" (using hide-if)
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	matmarex
	Feb 28 2020, 9:07 PM

Description

Special:GlobalPreferences does not deal well with "conditional preferences" (using hide-if). When a preference is hidden because the conditions to show it are not met, the checkbox to set it as global is still visible.

Currently this affects two preferences (testing on https://en.wikipedia.beta.wmflabs.org/wiki/Special:GlobalPreferences):

User profile → Newcomer homepage → Default to newcomer homepage from username link in personal tools (only shown if Display newcomer homepage is checked)

Appearance → Vector skin preferences → Use Legacy Vector (only shown if Skin → Vector is selected)

QA Results - Beta

AC	Status	Details
1	✅	T246491#6370891

QA Results - Prod

AC	Status	Details
1	✅	T246491#6387421

Details

	Subject	Repo	Branch	Lines +/-
	Pass hide-if through to global checkbox	mediawiki/extensions/GlobalPreferences	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T258581: [Bug] Additional checkbox appearing in global preferences page
T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference
T246162: Put skin preference in the correct place

Event Timeline

matmarex created this task.Feb 28 2020, 9:07 PM

Restricted Application added projects: Growth-Team, Community-Tech. · View Herald TranscriptFeb 28 2020, 9:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

matmarex added a project: Web-Team-Backlog.Feb 28 2020, 9:08 PM

matmarex mentioned this in T246162: Put skin preference in the correct place.Feb 29 2020, 1:10 AM

thanks for flagging!

Jdlrobson merged a task: T247065: orphaned item on Global Preferences form.Mar 16 2020, 2:10 PM

Jdlrobson added a subscriber: PerfektesChaos.

ovasileva triaged this task as Medium priority.Apr 2 2020, 4:55 PM

ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q4); removed Web-Team-Backlog.Apr 6 2020, 12:06 PM

@ovasileva I don't think this needs to be a priority right now. From my experience of global preferences this is likely to be a little challenging. Maybe this would be a good thing to pair up with growth team in near future since we are both impacted by it?

In T246491#6110942, @Jdlrobson wrote:

@ovasileva I don't think this needs to be a priority right now. From my experience of global preferences this is likely to be a little challenging. Maybe this would be a good thing to pair up with growth team in near future since we are both impacted by it?

That seems fine to me, I'll bring it up with @MMiller_WMF in our next 1:1

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-2019-20-Q4).May 8 2020, 9:11 PM

Jdlrobson moved this task from Needs triage to Technical on the Vector (legacy skin) board.May 15 2020, 4:59 PM

Jdlrobson mentioned this in T258493: [Spike 8hrs] "Use Legacy Vector" is not working as a global preference.Jul 24 2020, 7:11 PM

Jdlrobson mentioned this in T258581: [Bug] Additional checkbox appearing in global preferences page.Jul 26 2020, 8:37 PM

Jdlrobson merged a task: T258581: [Bug] Additional checkbox appearing in global preferences page.

Jdlrobson added subscribers: matej_suchanek, Stryn, Ammarpad, IKhitron.

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Jul 28 2020, 12:37 PM

ovasileva raised the priority of this task from Medium to High.Jul 29 2020, 4:03 PM

@ovasileva @JTannerWMF I can't get this extension setup locally. If I (and I imagine any of our team) was to tackle this it would likely take us quite some time. Could we reach out to community tech to get help with this one? https://www.mediawiki.org/wiki/Developers/Maintainers#MediaWiki_extensions_deployed_on_the_Wikimedia_Cluster

Yup can do @Jdlrobson

CC: @ARamirez_WMF headed your way!

Change 618171 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/GlobalPreferences@master] Pass hide-if through to global checkbox

https://gerrit.wikimedia.org/r/618171

gerritbot added a project: Patch-For-Review.Aug 4 2020, 5:15 AM

I'm not 100% sure I've read it all right, but this might just be a matter of passing hide-if through to the global checkbox.

ovasileva moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Aug 4 2020, 5:20 PM

ovasileva set the point value for this task to 3.Aug 4 2020, 5:33 PM

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson assigned this task to Edtadros.Aug 4 2020, 7:19 PM

Jdlrobson moved this task from Ready for Development to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 618171 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Pass hide-if through to global checkbox

https://gerrit.wikimedia.org/r/618171

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2020, 8:10 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA steps

Go to https://en.wikipedia.beta.wmflabs.org/wiki/Special:GlobalPreferences

✅ AC1: User profile → Newcomer homepage → Default to newcomer homepage from username link in personal tools (only shown if Display newcomer homepage is checked)

Aug-08-2020 11-23-29.gif (203×640 px, 509 KB)

✅ AC2: Appearance → Vector skin preferences → Use Legacy Vector (only shown if Skin → Vector is selected)

Aug-08-2020 11-24-44.gif (307×640 px, 977 KB)

Edtadros updated the task description. (Show Details)Aug 8 2020, 6:29 PM

Test Result - PROD

Status: ✅ PASS
Environment: euwiki
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA steps

Go to https://eu.wikipedia.org/wiki/Berezi:GlobalPreferences

✅ AC1: User profile → Newcomer homepage → Default to newcomer homepage from username link in personal tools (only shown if Display newcomer homepage is checked)

Aug-16-2020 09-08-23.gif (174×640 px, 1 MB)

✅ AC2: Appearance → Vector skin preferences → Use Legacy Vector (only shown if Skin → Vector is selected)

Aug-16-2020 09-10-15.gif (283×640 px, 1 MB)

Edtadros updated the task description. (Show Details)Aug 16 2020, 4:13 PM

JTannerWMF assigned this task to phuedx.Aug 18 2020, 5:13 PM

Thanks to @Samwilson for the fix and to @Jdlrobson for the merge.

Special:GlobalPreferences does not deal well with "conditional preferences" (using hide-if)Closed, ResolvedPublic3 Estimated Story PointsActions

Description

QA Results - Beta

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA steps

Test Result - PROD

QA steps

Special:GlobalPreferences does not deal well with "conditional preferences" (using hide-if)
Closed, ResolvedPublic3 Estimated Story Points
Actions