Maniphest T247868

Parsoid should use Assert::UnreachableException
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Mar 17 2020, 4:32 PM

Tags

Referenced Files

None

Subscribers

Description

T247093: Add Assert::UnreachableException added Assert::UnreachableException (instead of Assert::unreachable() as I'd originally proposed). Parsoid should swap code which currently calls PHPUtils::unreachable() to throw new UnreachableException() once the next version of the wikimedia/assert library is released.

Details

	Subject	Repo	Branch	Lines +/-
	Bump parsoid to 0.16.0-a20	mediawiki/vendor	master	+413 -145
	Switch uses of Assert:unreachable() to throwing an UnreachableException	mediawiki/services/parsoid	master	+45 -31

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		cscott	T247868 Parsoid should use Assert::UnreachableException
		Resolved		Zabe	T267952 Release mediawiki/assert 0.5.1

Event Timeline

cscott created this task.Mar 17 2020, 4:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2020, 4:32 PM

cscott moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Mar 17 2020, 4:33 PM

• ssastry triaged this task as Medium priority.Mar 24 2020, 4:31 AM

cscott changed the task status from Open to Stalled.Nov 16 2020, 5:59 PM

cscott added a subtask: T267952: Release mediawiki/assert 0.5.1.

Jdforrester-WMF closed subtask T267952: Release mediawiki/assert 0.5.1 as Resolved.Dec 21 2021, 11:56 AM

Jdforrester-WMF changed the task status from Stalled to In Progress.Dec 21 2021, 12:26 PM

Change 749168 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/parsoid@master] Switch uses of Assert:unreachable() to throwing an UnreachableException

https://gerrit.wikimedia.org/r/749168

gerritbot added a project: Patch-For-Review.Dec 21 2021, 12:30 PM

Change 749168 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Switch uses of Assert:unreachable() to throwing an UnreachableException

https://gerrit.wikimedia.org/r/749168

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2022, 6:30 PM

Jdforrester-WMF closed this task as Resolved.Aug 12 2022, 6:34 PM

Change 827533 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a20

https://gerrit.wikimedia.org/r/827533

gerritbot added a project: Patch-For-Review.Aug 29 2022, 5:03 PM

Change 827533 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a20

https://gerrit.wikimedia.org/r/827533

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2022, 6:30 PM