Revision history page no longer properly displays federated properties
Closed, ResolvedPublicBUG REPORT
Actions

Description

Revision History page

With modheader off: Revision history pages now display all properties as deleted and linked to a non-existent local page (this is not the expected behavior per resolved story T249836)
With modheader on: the behavior is the same, which does not conform to the BDD

Expected Results: see T249836

Details

Subject	Repo	Branch	Lines +/-
FP: Use correct interwiki for fed props entity source	mediawiki/extensions/Wikibase	master	+27 -9
Make EntityLinkTargetEntityIdLookup, entitysources and fed props work together	mediawiki/extensions/Wikibase	master	+9 -44
FP: use the local ns id for properties in entitysources	mediawiki/extensions/Wikibase	master	+10 -11

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T252015 [EPIC] Handling failed requests when federated properties are enabled
Resolved		None	T255972 Handling failed requests to the federation source Wiki when formatting edit summaries
Resolved	BUG REPORT	Addshore	T258564 Revision history page no longer properly displays federated properties

Event Timeline

• Samantha_Alipio_WMDE created this task.Jul 22 2020, 8:17 AM

• Samantha_Alipio_WMDE moved this task from Backlog to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.

• Samantha_Alipio_WMDE updated the task description. (Show Details)Jul 22 2020, 8:35 AM

• Samantha_Alipio_WMDE set the point value for this task to 5.

Addshore removed the point value for this task.Jul 22 2020, 8:37 AM

Addshore removed a project: Story.

Addshore triaged this task as High priority.Jul 22 2020, 8:42 AM

Addshore moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 4/6 (Hike 2) on the Wikibase - Federated Properties board.Jul 22 2020, 8:45 AM

Addshore edited projects, added Wikibase - Federated Properties (Sprint 4/6 (Hike 2)); removed Wikibase - Federated Properties.

Addshore claimed this task.Jul 23 2020, 1:49 PM

Addshore moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.

Restricted Application added a project: User-Addshore. · View Herald TranscriptJul 23 2020, 1:49 PM

Change 615745 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] FP: use the local ns id for properties in entitysources

https://gerrit.wikimedia.org/r/615745

gerritbot added a project: Patch-For-Review.Jul 23 2020, 2:10 PM

Change 615756 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] WIP DNM pointers to solving T258564

https://gerrit.wikimedia.org/r/615756

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 4 2020, 1:15 PM

Change 615745 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: use the local ns id for properties in entitysources

https://gerrit.wikimedia.org/r/615745

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 5 2020, 1:00 PM

Rosalie_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 6 2020, 9:47 AM

Change 615756 abandoned by Addshore:
[mediawiki/extensions/Wikibase@master] Make EntityLinkTargetEntityIdLookup, entitysources and fed props work together

Reason:

https://gerrit.wikimedia.org/r/615756

Change 618991 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] FP: Use correct interwiki for fed props entity source

https://gerrit.wikimedia.org/r/618991

Addshore moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 7 2020, 2:38 PM

Change 618991 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Use correct interwiki for fed props entity source

https://gerrit.wikimedia.org/r/618991

Addshore moved this task from Peer Review to Done on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 12 2020, 10:20 AM

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.5; 2020-08-18); removed MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 12 2020, 11:01 AM

• Samantha_Alipio_WMDE closed this task as Resolved.Aug 17 2020, 11:56 AM