Replace deprecated ve.init.mw.Target#getHtml
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	santhosh
	Aug 5 2020, 12:01 PM

Description

CX2 publishing shows the warning: ve.init.mw.Target#getHtml is deprecated. Use mw.libs.ve.targetSaver.getHtml.

Fix it by replacing with recommended method.

Details

	Subject	Repo	Branch	Lines +/-
	Replace deprecated ve.init.mw.Target#getHtml with mw.libs.ve.targetSaver.getHtml	mediawiki/extensions/ContentTranslation	master	+1 -1

Customize query in gerrit

Event Timeline

santhosh created this task.Aug 5 2020, 12:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2020, 12:01 PM

Set to high priority since we don't want to see the publishing feature failing at any cost.

santhosh claimed this task.Aug 6 2020, 6:47 AM

Change 618700 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Replace deprecated ve.init.mw.Target#getHtml with mw.libs.ve.targetSaver.getHtml

https://gerrit.wikimedia.org/r/618700

gerritbot added a project: Patch-For-Review.Aug 6 2020, 6:48 AM

santhosh moved this task from Priority Backlog to Needs QA on the Language-Team (Language-2020-July-September) board.Aug 6 2020, 12:54 PM

what version is this going to be deployed in?

I'm still seeing this in the console on cx2

https://gerrit.wikimedia.org/r/618700 is not merged yet

santhosh moved this task from Pending input for QA to In Review on the Language-Team (Language-2020-July-September) board.Aug 10 2020, 5:24 AM

In T259698#6371714, @santhosh wrote:

https://gerrit.wikimedia.org/r/618700 is not merged yet

You can test it on cx2 after merge and it should be available in Production (All Wikis) by Wednesday EOD.

Change 618700 merged by Nik Gkountas:
[mediawiki/extensions/ContentTranslation@master] Replace deprecated ve.init.mw.Target#getHtml with mw.libs.ve.targetSaver.getHtml

https://gerrit.wikimedia.org/r/618700

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 3:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 10 2020, 4:00 PM

• Rileych moved this task from In Review to Needs QA on the Language-Team (Language-2020-July-September) board.Aug 13 2020, 12:38 PM

• Jpita moved this task from Needs QA to Done on the Language-Team (Language-2020-July-September) board.Aug 13 2020, 4:47 PM

Pginer-WMF closed this task as Resolved.Aug 14 2020, 2:02 PM