Move `getEntityNamespaceLookup` from `GenericServices`
Closed, ResolvedPublic
Actions

Description

As mentioned in the TODO comments, the logic in method getEntityNamespaceLookup does not belong in generic services as it relies on wiki / repo specific settings, and therefore should be moved to the SingleEntitySourceServices and MultipleEntitySourceServices classes.

Service added to SingleEntitySourceServices
Service added to MultipleEntitySourceServices
GenericServices EntityNamespaceLookup should not be used & should be removed.

Details

	Subject	Repo	Branch	Lines +/-
	Move getEntityNamespaceLookup from Generic to Single and Multiple EntitySourceServices	mediawiki/extensions/Wikibase	master	+84 -84

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T205268 Many services in GenericServices are not actually that generic.
		Resolved		ItamarWMDE	T260426 Move `getEntityNamespaceLookup` from `GenericServices`

Event Timeline

ItamarWMDE created this task.Aug 14 2020, 11:18 AM

ItamarWMDE mentioned this in T260163: Investigate which of the GenericServices are actually generic vs those that are not.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Aug 14 2020, 12:15 PM

ItamarWMDE removed ItamarWMDE as the assignee of this task.Aug 14 2020, 1:26 PM

ItamarWMDE removed projects: Story, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)), User-Addshore, Wikidata-Trailblazing-Exploration.Aug 14 2020, 1:28 PM

Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Aug 17 2020, 9:25 AM

Addshore updated the task description. (Show Details)Aug 17 2020, 9:34 AM

ItamarWMDE claimed this task.Aug 17 2020, 2:30 PM

ItamarWMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 620912 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Move getEntityNamespaceLookup from Generic to Single and Multiple EntitySourceServices

https://gerrit.wikimedia.org/r/620912

gerritbot added a project: Patch-For-Review.Aug 18 2020, 11:26 AM

ItamarWMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 18 2020, 12:21 PM

Change 620912 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move getEntityNamespaceLookup from Generic to Single and Multiple EntitySourceServices

https://gerrit.wikimedia.org/r/620912

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25).Aug 19 2020, 5:50 AM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 19 2020, 9:17 AM

Michael removed a project: Patch-For-Review.Aug 21 2020, 2:27 PM

WMDE-leszek closed this task as Resolved.Sep 23 2020, 4:16 PM

WMDE-leszek updated the task description. (Show Details)

WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.