| matmarex | |
| Apr 21 2021, 7:14 PM |
| F35498920: Screen Shot 2022-08-30 at 3.36.07 PM.png | |
| Aug 30 2022, 10:59 PM |
| F35498925: Screen Shot 2022-08-30 at 3.36.52 PM.png | |
| Aug 30 2022, 10:59 PM |
| F35484498: Screen Shot 2022-08-22 at 1.58.25 PM.png | |
| Aug 22 2022, 11:05 PM |
| F35358552: Screen Shot 2022-07-29 at 1.55.02 PM.png | |
| Jul 29 2022, 9:35 PM |
| F35358547: Screen Shot 2022-07-29 at 12.00.44 PM.png | |
| Jul 29 2022, 9:35 PM |
| F35327097: Bugfix-preferences.gif | |
| Jul 20 2022, 10:56 PM |
| F35327009: Screen Shot 2022-07-20 at 1.49.18 PM.png | |
| Jul 20 2022, 8:51 PM |
| F35327011: Screen Shot 2022-07-20 at 1.49.28 PM.png | |
| Jul 20 2022, 8:51 PM |
Preferences link in mobile notifications is broken on phones with screen width of less than 720px (works on tablets).
https://en.m.wikipedia.org/wiki/Special:Notifications (to find this page, click → All notifications).
Broken:  | Looks good at wider screen size:  |
The problem is caused by this CSS rule: (but I don't know what else it does, so I'm not submitting a patch)
@media (max-width: 720px)
.mw-echo-ui-overlay .oo-ui-clippableElement-clippable {
width: 100% !important;
}Broken:  | Fixed:  |
Change 814912 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):
[mediawiki/extensions/Echo@master] Echo mobile: remove CSS media query class
Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0457351a6e/w
@ovasileva Hello! I think we need a review from your team for this patch. Thanks in advance!
Echo works differently on Minerva depending on whether you are on mobile or desktop domain (some users set their desktop skin to Minerva)
In the latter I'm seeing a bug with the suggested change on https://en.wikipedia.org/wiki/Main_Page?useskin=minerva
Note the gap to the right of the overlay
Suggestion: could we update the CSS rule to only apply to this overlay?
Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:
>>! In T280839#8087998, @Scardenasmolinar wrote:
@ovasileva Hello! I think we need a review from your team for this patch. Thanks in advance!
@Scardenasmolinar it was pointed out to be by @Jdlrobson that echo-related bits of this extension are owned by growth, so we should ping them about review. Sorry for the inaccurate guidance on this one!
Sorry about that. Based on feedback from Jon, I have fixed the error without breaking the Echo notification overlay. A review is appreciated :)
Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/60040461f3/w
Change 814912 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Echo mobile: add CSS media query class
Checked in beta cluster (and wmf.22): the link to Preferences (in the absence of "Mark all as read in selected wiki [...]") is displayed correctly. When "Mark as read..." link is present - the Preference link will be left-aligned and not visible; "Mark as read..." link will be partially visible (the issue was also reported in T287057: [wmf.14] mobile - mw-echo-ui-specialHelpMenuWidget-menu hides "Preference" label ):
 | width: 393  |
Change 820549 had a related patch set uploaded (by Eigyan; author: Eigyan):
[mediawiki/extensions/Echo@master] Echo mobile: add CSS media query class - bug fix
Test wiki created on Patch demo by EIgyan (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/64410b8c88/w
Change 820549 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Echo mobile: add CSS media query class - bug fix
Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:
Checked on test.m.wiki wmf.27
The issue reported in the ticket is fixed - closing as Resolved.
There are two super minor display issues:
-for the vertical orientation (560x740) the drop-down fits rather tightly
Test wiki on Patch demo by EIgyan (WMF) using patch(es) linked to this task was deleted:
