Page scan is not displayed when 2010 toolbar is disabled
Open, HighPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Ankry
	Dec 9 2021, 4:43 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

disable the "Enable the editing toolbar" in Preferences -> Editing
edit any page in the Page namespace in Wikisource using standard wikicode editor

What happens?:

scan appears for a while in the right-half of the screen and then disappears leaving blue square in its expected location
no error reported in console

What should have happened instead?:

The scan should remain in the right part of the screen (assuming the default, vertical mode is used)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
The problem did not exist before 2021-12-08
Tested on Firefox, but probably browser does not matter

Details

	Subject	Repo	Branch	Lines +/-
	Move horizontal/vertical layout to CSS only	mediawiki/extensions/ProofreadPage	wmf/1.38.0-wmf.13	+34 -24
	Move horizontal/vertical layout to CSS only	mediawiki/extensions/ProofreadPage	master	+34 -24

Customize query in gerrit

Related Objects

Mentioned In: T297338: Switching to horizontal mode in ProofreadPage leaves the edit window narrow
T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie"
Mentioned Here: rEPRP9eab4de20896: OSD: Prevent original image from getting overwritten by OSD

Event Timeline

Ankry created this task.Dec 9 2021, 4:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2021, 4:43 AM

Ankry added projects: ProofreadPage, Regression.Dec 9 2021, 4:44 AM

Something is wrong with it in general: with the toolbar, h-mode is broken too. A quick bisect finds it was introduced with 9eab4de208966d3f88b4aa956a467231ea408bdf.

Quick user-side fix for the non-toolbar vertical layout appears to be some CSS:

#prp-page-image-openseadragon-vertical {
	height: 100%;
}

Change 745460 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/ProofreadPage@master] Always setup preferences, even without WikiEditor

https://gerrit.wikimedia.org/r/745460

gerritbot added a project: Patch-For-Review.Dec 9 2021, 7:30 AM

In T297339#7558451, @Inductiveload wrote:
Quick user-side fix for the non-toolbar vertical layout appears to be some CSS:
#prp-page-image-openseadragon-vertical {
	height: 100%;
}

It works. Thanks!

Samwilson mentioned this in T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie".Dec 10 2021, 4:16 AM

@Aklapper Are we able to find someone to review this? This is a break stopping work that has a solution, and having to get people to do css fixes is less than ideal. Thanks.

@Billinghurst: See https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews and the ProofreadPage entry on https://www.mediawiki.org/wiki/Developers/Maintainers , basically... :-/

Change 745460 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Move horizontal/vertical layout to CSS only

https://gerrit.wikimedia.org/r/745460

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 17 2021, 8:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 17 2021, 8:10 AM

Change 748095 had a related patch set uploaded (by Inductiveload; author: Samwilson):

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.13] Move horizontal/vertical layout to CSS only

https://gerrit.wikimedia.org/r/748095

gerritbot added a project: Patch-For-Review.Dec 17 2021, 11:08 AM

Inductiveload mentioned this in T297338: Switching to horizontal mode in ProofreadPage leaves the edit window narrow.Dec 22 2021, 8:26 AM

Change 748095 abandoned by Inductiveload:

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.13] Move horizontal/vertical layout to CSS only

Reason:

other change implemented this