Following on this https://phabricator.wikimedia.org/T306746#8118371
We need to update the loading animation to be same size as the infobox.
Screenshot:
• TThoabala | |
Aug 2 2022, 2:24 PM |
F35501330: image.png | |
Aug 31 2022, 3:49 PM |
F35490803: infobox_loading_size.png | |
Aug 26 2022, 8:33 AM |
F35484174: Screenshot at Aug 22 18-29-00.png | |
Aug 22 2022, 4:33 PM |
F35382172: loading.png | |
Aug 2 2022, 3:51 PM |
Following on this https://phabricator.wikimedia.org/T306746#8118371
We need to update the loading animation to be same size as the infobox.
Screenshot:
Change 824187 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):
[mediawiki/extensions/IPInfo@master] Load animation same size as infobox
I am happy with the patch , but I think we might be adding some extra space at the end of info box...
Thanks for catching that! No, we shouldn't be adding an extra space at the bottom of the box.
Change 824187 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Load animation same size as infobox
Example of the loading animation on Vector 2022:
I notice the margin at the bottom is slightly bigger than the right and left. This is the same for all the skins. @Prtksxna is this OK?
I tested on Vector 2010, Vector 2022, Minerva, MonoBook and Timeless. We haven't changed the "jump" behaviour from T306746#8133298.
Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (2eaf682) 08:27, 25 August 2022.
Thanks Dom! We should maintain the same margin from the bottom as well. @Cyndymediawiksim @TThoabala, I'm moving this to In Progress, hope that is okay!
Change 828478 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):
[mediawiki/extensions/IPInfo@master] Loading animation is now same size as the infobox
Change 828478 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Make loading animation the same size as the infobox
I've merged the follow-up, assuming that this is close enough:
The space at the bottom is slightly larger than the space at the sides, but I think we'd need to do a px/em calculation to get it exact. @Prtksxna How does this look?