| ifried | |
| Aug 17 2022, 10:03 PM |
| F35491973: IMG_2372.gif | |
| Aug 26 2022, 8:00 PM |
| F35492017: IMG_2374.gif | |
| Aug 26 2022, 8:00 PM |
| F35492012: Screen Shot 2022-08-26 at 2.16.35 PM.png | |
| Aug 26 2022, 8:00 PM |
| F35492047: IMG_2375.gif | |
| Aug 26 2022, 8:00 PM |
| F35491971: Screenshot 2022-08-26 at 1.34.22 PM.png | |
| Aug 26 2022, 8:00 PM |
| F35470692: Screen Shot 2022-08-17 at 6.28.23 PM.png | |
| Aug 17 2022, 10:30 PM |
| F35470693: Screen Shot 2022-08-17 at 6.28.31 PM.png | |
| Aug 17 2022, 10:30 PM |
| F35470699: Screen Shot 2022-08-17 at 6.30.17 PM.png | |
| Aug 17 2022, 10:30 PM |
Acceptance Criteria:
Visual examples of things to fix:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Improve layout of EventDetails on smaller screens | mediawiki/extensions/CampaignEvents | master | +84 -59 |
@gonyeahialam Hello! Can you add more details to this ticket so it is ready for development? Specifically, the acceptance criteria should state what the change should be, so please add in details on the expected behavior. Thank you!
Change 824520 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Improve layout of EventDetails on smaller screens
Test wiki created on Patch demo by CmeloV using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/4b43694612/w
Change 824520 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Improve layout of EventDetails on smaller screens
✅ Event details page content should be responsive and fit the mobile screen size.
✅ Event details section should be above the participant list on mobile.
✅ Clicking on View event page should take you to the mobile event page (not desktop)
One thing I forgot saying about:
Clicking on View event page should take you to the mobile event page (not desktop)
This will possibly only work when the event page is on the same wiki. There's no way to get a URL to the mobile version of another wiki. I'm not sure if we also use cookies or sth like that to remember whether to open the mobile version, so it may still work, but it's not guaranteed.
this has worked for me so far in testing - do you have an example where you think it would be less likely to work so I can test there as well?
I'm not sure. Maybe if the event page is on wiki A, and you switch to the desktop version there. Then go to EventDetails on wiki B and follow the link to wiki A it should send you to the desktop version? But again, I'm not really sure how it works.