As can be seen from the revisions automatically marked as patrolled by Urbanecmbot on Meta-Wiki due to them being unpatrolled edits by users with the autopatrol right, edits to translated pages no longer follow this permission. This includes edits by FuzzyBot in particular. Note that the corresponding edits to the units in the "Translations" namespace do get patrolled automatically as expected.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T182943 Move namespaced extensions to use PSR-4 autoloading | |||
| Open | None | T278278 Adopt PSR-4 namespaces in WMF-deployed extensions/skins | |||
| Open | None | T193166 Adopt PSR-4 namespaces in Translate and modernize code | |||
| Resolved | Wangombe | T312006 Move classes under tag folder to namespace | |||
| Resolved | BUG REPORT | abi_ | T315708 Edits to translated pages left unpatrolled |
Event Timeline
Comment Actions
f09d649f4ed01d6f6b09a9d521dc0e12298bd770 (by @Wangombe) switched from the deprecated WikiPage::doUserEditContent to calling PageUpdater::saveRevision directly. The deprecation notice is:
@deprecated since 1.36, use PageUpdater::saveRevision instead. Note that the new method expects callers to take care of checking EDIT_MINOR against the minoredit right, and to apply the autopatrol right as appropriate.
Checking the minor edit right is unnecessary because the flags come from another PageUpdater::saveRevision call, so we can assume the user right has been checked; however, the patrol status apparently isn’t automatically inherited. I think the clean solution would be if the hook got the patrol status, so that we don’t have to reimplement the checks in Translate. As a temporary hotfix, we could switch back to the deprecated WikiPage::doUserEditContent.
Comment Actions
Change 825747 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):
[mediawiki/extensions/Translate@master] RenderTranslationPageJob: Add patrol status for translation page
Comment Actions
Change 825747 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] RenderTranslationPageJob: Add patrol status for translation page
Comment Actions
Change 827577 had a related patch set uploaded (by Urbanecm; author: Abijeet Patro):
[mediawiki/extensions/Translate@wmf/1.39.0-wmf.26] RenderTranslationPageJob: Add patrol status for translation page
Comment Actions
Change 827577 merged by Urbanecm:
[mediawiki/extensions/Translate@wmf/1.39.0-wmf.26] RenderTranslationPageJob: Add patrol status for translation page
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-08-30T13:52:20Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.26/extensions/Translate/src/PageTranslation/RenderTranslationPageJob.php: 75d8e6cba30e20f3ee91bb04f1b59423c96244b6: RenderTranslationPageJob: Add patrol status for translation page (T315708) (duration: 03m 59s)
Comment Actions
Looking at: https://meta.wikimedia.org/wiki/Special:Log?type=patrol&user=UrbanecmBot, this appears to be fixed now.
Comment Actions
This issue might have re-appeared? There's a fresh report at Meta_talk:Babylon about edits not being correctly autopatrolled. (I'm not sure if this needs a fresh task, or if it's a re-occurrence of the underlying issue here.)