Make GrowthExperiments\Tests\MentorHooksTest::testOnUserGetRights more robust
Closed, ResolvedPublic
Actions

Description

I've seen two mentions of this test (E.g. https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/826250/2#message-75b27dfae5af3d30ec28ab1a70c8c99e7b9a7c31) failing non-deterministically, we should take a look and make it more robust.

Details

	Subject	Repo	Branch	Lines +/-
	tests: Use fake timer for MentorHooksTest	mediawiki/extensions/GrowthExperiments	master	+8 -2

Customize query in gerrit

Event Timeline

kostajh created this task.Aug 24 2022, 8:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2022, 8:04 PM

kostajh triaged this task as Medium priority.Aug 24 2022, 8:04 PM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

This is causing CI failures on several random patches:

Change 826904 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] tests: Use fake timer for MentorHooksTest

https://gerrit.wikimedia.org/r/826904

gerritbot added a project: Patch-For-Review.Aug 26 2022, 7:49 PM

Another flaky result at Gerrit change: mediawiki/core / Jenkins build.

Krinkle added a project: ci-test-error.Aug 26 2022, 10:43 PM

Change 826904 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: Use fake timer for MentorHooksTest

https://gerrit.wikimedia.org/r/826904

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2022, 11:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.27; 2022-08-29).Aug 27 2022, 12:01 AM

Is there anything else to do, since r826904 is merged now?

Urbanecm_WMF moved this task from New Tasks to Prioritized on the GrowthExperiments-Mentorship board.Aug 28 2022, 5:06 PM

Umherirrender closed this task as Resolved.Aug 28 2022, 9:07 PM

Umherirrender claimed this task.

In T316154#8191884, @Urbanecm_WMF wrote:

Is there anything else to do, since r826904 is merged now?

Thanks for fixing this, @Urbanecm_WMF!

In T316154#8192950, @kostajh wrote:

In T316154#8191884, @Urbanecm_WMF wrote:

Is there anything else to do, since r826904 is merged now?

Thanks for fixing this, @Urbanecm_WMF!

I can't take the credit here. The thanks goes to @Umherirrender (who uploaded the patch) and Krinkle, who merged it. Thanks both!

Make GrowthExperiments\Tests\MentorHooksTest::testOnUserGetRights more robustClosed, ResolvedPublicActions

Description

Details

Event Timeline

Make GrowthExperiments\Tests\MentorHooksTest::testOnUserGetRights more robust
Closed, ResolvedPublic
Actions