| Tacsipacsi | |
| Aug 25 2022, 9:54 AM |
| F35489595: Screenshot 2022-08-25 at 11-46-24 MediaWiki.png | |
| Aug 25 2022, 9:54 AM |
| ✅ enwiki | ❗️ mediawiki.org |
|---|---|
 |  |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | jeena | T314189 1.39.0-wmf.28 deployment blockers | ||
| Resolved | BUG REPORT | matmarex | T316196 Timeless’ namespace tabs are duplicated |
git bisect says this is caused by rMW5fa2b6362bda: SpecialPages: Can formally register navigation links (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/813710)
This seems to be a similar issue to T300100. Timeless tries to display all of the navigation links, and some of them are now presented twice.
Change 826633 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/skins/Timeless@master] Hide new 'associatedPages' navigation items
Change 826633 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Hide new 'associatedPages' navigation items
Change 826610 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/skins/Timeless@wmf/1.39.0-wmf.26] Hide new 'associatedPages' navigation items
Change 826610 merged by jenkins-bot:
[mediawiki/skins/Timeless@wmf/1.39.0-wmf.26] Hide new 'associatedPages' navigation items
Mentioned in SAL (#wikimedia-operations) [2022-08-25T20:35:43Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.26/skins/Timeless/: ba0e981890aa6eb61598e4df786f7122e17b3002: Hide new associatedPages navigation items (T316196) (duration: 03m 41s)
This is the second time this has happened now (this also happened with categories in T300100). Given the backports in both situations, I think we should update Timeless so it doesn't blindly render things it doesn't know about, particularly since this array is likely to expand further in future. Thoughts?
It’s annoying if Timeless renders things it should not, but it would be far worse if it didn’t render things it should—imagine if these incidents happened in the other way round, and people would’ve had no access to the talk page or the categories for over a day. Is it possible to create a CI rule instead that would warn when a new “thing” appears that Timeless doesn’t know about?
Change 827597 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] SkinTemplate: Unset modern menus in QuickTemplate-based skins
Change 827598 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Timeless@master] Do not unset navigation keys
This is happening again due to an unrelated change (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/828096) which can't be reverted as it has consequences on other skins.
After looking at this Timeless is patching over an issue that's really a problem in core: https://gerrit.wikimedia.org/r/827597 provides a more robust solution here (and a test to guard against it in future).
I think it makes sense to do it, actually. The changes will only cause Timeless to omit newly added menus, but newly added items to existing menus will display. It's probably not a good idea to display a whole menu's worth of items in the middle of the actions menu, as we learned twice already. And other skins also won't display any newly added menus, so hopefully people will consider that when adding them.
Change 827597 merged by jenkins-bot:
[mediawiki/core@master] SkinTemplate: Unset modern menus in QuickTemplate-based skins
Change 827598 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Do not unset navigation keys
Thanks ! https://pixel.wmcloud.org/reports/web-maintained/index.html now reporting no regressions and this should be pretty stable going forward.