Create Task
Maniphest T329200

Enable read new support in Special:Investigate's 'Timeline' tab
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Now that CheckUser writes to the new tables for event table migration (T330158), reading from these tables when the migration stage is set to read new can commence.

This task is to add support to read new in Special:Investigate's 'Timeline' tab.

Acceptance criteria
  • Alias the current query info fields in TimelineService, TimelinePager and TimelineRowFormatter use aliases for the cu_changes fields that are selected (T347102)
  • Update the TimelineService to select results from the three tables if read new is set
  • Use LogFormatter generated actiontext for entries that are read from the new tables.
  • Link to the specific log ID for entries that are read from the new tables.

Details

SubjectRepoBranchLines +/-
Add read new support to the TimelineServicemediawiki/extensions/CheckUsermaster+525 -87
Add test data for new result tables in TimelinePagerTestmediawiki/extensions/CheckUsermaster+267 -63
Update TimelineRowFormatter to read new for event table migrationmediawiki/extensions/CheckUsermaster+260 -57
Remove outdated note in TimelineRowFormatter::getUserLinksmediawiki/extensions/CheckUsermaster+0 -2
Pass ServiceOptions to ChangeServicemediawiki/extensions/CheckUsermaster+46 -1
[WIP] Implement read new support for Investigate timeline modemediawiki/extensions/CheckUsermaster+197 -66
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Feb 8 2023, 4:54 PM
Dreamy_Jazz added a subtask: T328988: Create a SelectQueryBuilder that allows selecting from all three tables.
Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.Feb 8 2023, 11:56 PM
Dreamy_Jazz moved this task from General / Unsorted to Investigate on the CheckUser board.
Dreamy_Jazz closed subtask T328988: Create a SelectQueryBuilder that allows selecting from all three tables as Resolved.Apr 23 2023, 2:12 PM
Dreamy_Jazz added a parent task: T340995: Display client hint data in Special:Investigate.Jul 13 2023, 7:55 PM
gerritbot added a comment.Jul 20 2023, 9:15 PM

Change 940252 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Implement read new support for Investigate timeline mode

https://gerrit.wikimedia.org/r/940252

gerritbot added a project: Patch-For-Review.Jul 20 2023, 9:15 PM
Dreamy_Jazz moved this task from Untriaged to Blocked/Stalled on the Anti-Harassment board.Jul 20 2023, 9:15 PM
Dreamy_Jazz mentioned this in T341688: Create LogFormatter for cu_private_event log events.Jul 21 2023, 3:43 PM
Dreamy_Jazz renamed this task from Use the CheckUserUnionSelectQueryBuilder in Special:Investigate timeline tab to Enable read new support in Special:Investigate's 'Timeline' tab.Sep 21 2023, 5:52 PM
Dreamy_Jazz updated the task description. (Show Details)
Dreamy_Jazz edited projects, added Anti-Harassment (AHaT Sprint 32 - Baseball Cap); removed Anti-Harassment.
Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Dreamy_Jazz mentioned this in T329189: Add read new support to Special:Investigate for event table migration.Sep 21 2023, 6:03 PM
gerritbot added a comment.Sep 21 2023, 6:08 PM

Change 940252 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] [WIP] Implement read new support for Investigate timeline mode

Reason:

https://gerrit.wikimedia.org/r/940252

Dreamy_Jazz claimed this task.Sep 21 2023, 6:09 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 21 2023, 6:10 PM
Dreamy_Jazz updated the task description. (Show Details)Sep 21 2023, 6:12 PM
Dreamy_Jazz added a subtask: T347102: Alias column names in Special:Investigate to not include the "cuc_" prefix.
Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.Oct 2 2023, 2:38 PM
Dreamy_Jazz edited projects, added Anti-Harassment; removed Anti-Harassment (AHaT Sprint 32 - Baseball Cap).

Moving out of the current sprint.

Dreamy_Jazz added a subtask: T362152: Improve test coverage on Special:Investigate code.Apr 11 2024, 11:35 AM
Dreamy_Jazz closed subtask T362152: Improve test coverage on Special:Investigate code as Resolved.Apr 19 2024, 3:45 PM
Dreamy_Jazz added a subtask: T363376: Move code that groups and sorts the rows from the CheckUser result tables to the CheckUserLookupUtils service to reduce duplication.Apr 24 2024, 8:04 PM
Dreamy_Jazz added a subtask: Restricted Task.Apr 25 2024, 7:41 AM
Dreamy_Jazz removed a subtask: Restricted Task.Apr 25 2024, 9:50 AM
Dreamy_Jazz closed subtask T363376: Move code that groups and sorts the rows from the CheckUser result tables to the CheckUserLookupUtils service to reduce duplication as Declined.May 1 2024, 7:41 PM
gerritbot added a comment.May 2 2024, 12:42 PM

Change #1026550 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use IExpression objects in ChangeService

https://gerrit.wikimedia.org/r/1026550

gerritbot added a project: Patch-For-Review.May 2 2024, 12:42 PM
Pppery removed a project: Patch-For-Review.May 10 2024, 1:09 AM
TAdeleye_WMF edited projects, added Trust and Safety Product Team (PM); removed Anti-Harassment.May 14 2024, 4:41 PM
Dreamy_Jazz moved this task from PM to Engineering on the Trust and Safety Product Team board.May 15 2024, 4:18 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Team (Engineering); removed Trust and Safety Product Team (PM).
Dreamy_Jazz edited projects, added Trust and Safety Product Team (PM), Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)); removed Trust and Safety Product Team (Engineering).
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.
Dreamy_Jazz closed subtask T347102: Alias column names in Special:Investigate to not include the "cuc_" prefix as Resolved.May 15 2024, 5:00 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Team (Engineering); removed Trust and Safety Product Team (PM).May 15 2024, 8:05 PM
Dreamy_Jazz claimed this task.May 16 2024, 10:53 AM
Dreamy_Jazz set the point value for this task to 3.
gerritbot added a comment.May 20 2024, 3:04 PM

Change #1034100 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Add read new support to Timeline pager

https://gerrit.wikimedia.org/r/1034100

gerritbot added a project: Patch-For-Review.May 20 2024, 3:04 PM
gerritbot added a comment.May 21 2024, 3:46 PM

Change #1034524 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Update TimelineRowFormatter to read new for event table migration

https://gerrit.wikimedia.org/r/1034524

gerritbot added a comment.May 21 2024, 5:58 PM

Change #1034550 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Pass ServiceOptions to ChangeService::__construct

https://gerrit.wikimedia.org/r/1034550

gerritbot added a comment.May 22 2024, 10:40 AM

Change #1034515 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove outdated note in TimelineRowFormatter::getUserLinks

https://gerrit.wikimedia.org/r/1034515

gerritbot added a comment.May 22 2024, 11:41 AM

Change #1034893 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add test data for new result tables in TimelinePagerTest

https://gerrit.wikimedia.org/r/1034893

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 22 2024, 3:46 PM
gerritbot added a comment.May 22 2024, 5:34 PM

Change #1034550 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Pass ServiceOptions to ChangeService

https://gerrit.wikimedia.org/r/1034550

gerritbot added a comment.May 24 2024, 1:18 PM

Change #1034524 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Update TimelineRowFormatter to read new for event table migration

https://gerrit.wikimedia.org/r/1034524

gerritbot added a comment.May 24 2024, 1:19 PM

Change #1034515 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove outdated note in TimelineRowFormatter::getUserLinks

https://gerrit.wikimedia.org/r/1034515

gerritbot added a comment.May 24 2024, 1:25 PM

Change #1034893 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add test data for new result tables in TimelinePagerTest

https://gerrit.wikimedia.org/r/1034893

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 24 2024, 2:00 PM
gerritbot added a comment.May 24 2024, 2:58 PM

Change #1034100 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add read new support to the TimelineService

https://gerrit.wikimedia.org/r/1034100

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)) board.May 28 2024, 10:21 AM
Dreamy_Jazz removed a project: Patch-For-Review.
dom_walden edited projects, added Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)); removed Trust and Safety Product Sprint (Sprint Shekere (13th May - 24th May)).Jun 3 2024, 10:09 AM
dom_walden moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.
dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Melodica (Jun 3 - Jun 14)) board.Jun 4 2024, 7:34 AM
dom_walden subscribed.

I have compared the results in the Timeline tab before and after this change. Direct comparison is a bit difficult but I have only seen a few differences.

  • For log events, we now include a link to Special:Log?page=<target> (where <target> includes things like the name of an article or User:<user>)
  • For log events, the performer and target names are links to their user pages (or Special:Contributions if they are a temp user)
  • For log events, we show the log reason
  • Edit summaries and log reasons are no longer in parentheses

Test environment: local docker CheckUser 2.5 (e98e323) 19:37, 3 June 2024.

Dreamy_Jazz closed this task as Resolved.Jun 4 2024, 8:06 AM
Dreamy_Jazz updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits