Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Michael
	Apr 20 2023, 10:09 AM

Description

The feature flag $wgWBRepoSettings['tmpEnableLabelsInApiSummaries'] was only introduced temporarily to enable a controlled roll-out. Since those labels are now part of our stable API response, we can remove it again.

See the changes associated with the parent task and subtasks for code that was added and now needs to be cleaned up.

A (likely incomplete) list of places to clean up:

Wikibase.default.php
Wikibase.ci.php
HtmlPageLinkRendererEndHookHandler (including shouldConvertNoBadTitle/shouldConvert)
HtmlPageLinkRendererEndHookHandlerTestBase::newInstance()
wmf-config/Wikibase.php
wmf-config/InitialiseSettings-labs.php:2347

Details

Subject	Repo	Branch	Lines +/-
HtmlPageLinkRendererEndHookHandler: Remove stray comment	mediawiki/extensions/Wikibase	master	+0 -1
Remove wmgWikibaseTmpEnableLabelsInApiSummaries feature flag	operations/mediawiki-config	master	+0 -15
Remove tmpEnableLabelsInApiSummaries feature flag	mediawiki/extensions/Wikibase	master	+4 -45

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	Lectrician1	T116762 Notifications in Echo on Wikidata should display label as well as Q id
Resolved	Arian_Bozorg	T330130 API changes Spring 2023
Resolved	Michael	T327062 Show entity labels in parsed edit summaries in API requests as well
Resolved	Lucas_Werkmeister_WMDE	T335107 Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again

Event Timeline

Michael created this task.Apr 20 2023, 10:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2023, 10:09 AM

Michael updated the task description. (Show Details)Apr 20 2023, 6:35 PM

Michael updated the task description. (Show Details)Apr 21 2023, 11:56 AM

Michael updated the task description. (Show Details)Apr 24 2023, 2:12 PM

Waiting for it being enabled on Wikidata and accepted by community and product. See also T335099

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 24 2023, 4:17 PM

Change 923622 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove tmpEnableLabelsInApiSummaries feature flag

https://gerrit.wikimedia.org/r/923622

Change 923623 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Remove wmgWikibaseTmpEnableLabelsInApiSummaries feature flag

https://gerrit.wikimedia.org/r/923623

Lucas_Werkmeister_WMDE changed the task status from Stalled to Open.May 26 2023, 2:56 PM

Lucas_Werkmeister_WMDE claimed this task.

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.

hoo moved this task from Peer Review to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.May 30 2023, 8:42 AM

Change 923622 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove tmpEnableLabelsInApiSummaries feature flag

https://gerrit.wikimedia.org/r/923622

Stalled until 1.41.0-wmf.12 is fully rolled out, i.e. we can probably deploy the config change after June 12.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).May 30 2023, 1:01 PM

Change 923623 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wmgWikibaseTmpEnableLabelsInApiSummaries feature flag

https://gerrit.wikimedia.org/r/923623

Mentioned in SAL (#wikimedia-operations) [2023-06-12T13:55:47Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:923623|Remove wmgWikibaseTmpEnableLabelsInApiSummaries feature flag (T335107)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-12T13:57:08Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde: Backport for [[gerrit:923623|Remove wmgWikibaseTmpEnableLabelsInApiSummaries feature flag (T335107)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-06-12T14:02:37Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:923623|Remove wmgWikibaseTmpEnableLabelsInApiSummaries feature flag (T335107)]] (duration: 06m 49s)

Lucas_Werkmeister_WMDE changed the task status from Stalled to Open.Jun 12 2023, 2:03 PM

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.

Maintenance_bot removed a project: Patch-For-Review.Jun 12 2023, 2:11 PM

Doesn’t look like there are any references left (this search covers both config and source code):

lucaswerkmeister-wmde@deploy1002 /srv/mediawiki-staging (master $ u=) $ grep -rlF -e tmpEnableLabelsInApiSummaries -e tmpWbsubscribersSensibleOutput
lucaswerkmeister-wmde@deploy1002 /srv/mediawiki-staging (master $ u=) $

karapayneWMDE moved this task from Our work done to 2023 completed tasks on the Wikidata Dev Team (Sprint-∞) board.Jun 28 2023, 7:47 AM

Change 939300 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] HtmlPageLinkRendererEndHookHandler: Remove stray comment

https://gerrit.wikimedia.org/r/939300

gerritbot added a project: Patch-For-Review.Jul 18 2023, 1:03 PM

Change 939300 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] HtmlPageLinkRendererEndHookHandler: Remove stray comment

https://gerrit.wikimedia.org/r/939300

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 1:30 PM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jul 18 2023, 2:00 PM