Replace AjaxBuildDiffHeaderItems with templates
Closed, ResolvedPublic

Description

This is a deprecated ajax dispatcher call. It should be possible to rework this to make use of templates.

The content it produces is a header above the two diffs, containing:

<div id="mw-fr-diff-headeritems"><form id="mw-fr-diff-dataform"><input type="hidden" value="858469997" name="oldid"><input type="hidden" value="858470036" name="newid"></form>
<table class="fr-diff-ratings"><tbody><tr><td style="text-align: center; width: 50%;"><span class="flaggedrevs-color-1">[accepted revision]</span></td><td style="text-align: center; width: 50%;"><span class="flaggedrevs-color-1">[accepted revision]</span></td></tr></tbody></table>
</div>

I think all the information should be present based on the action=review call, or can otherwise be retrieved from the log via action=query.

Event Timeline

TheDJ triaged this task as Medium priority.Sep 7 2018, 12:26 PM
TheDJ created this task.

Speaking of, I noticed it now insert it's markers in competition with the visual diff beta, creating a layout that is less than ideal.

Screen Shot 2018-09-07 at 14.29.28.png (1×1 px, 274 KB)

Isn't this done with removal of AjaxBuildDiffHeaderItems?

TheDJ claimed this task.

@Ladsgroup seems so...