Create Task
Maniphest T42787

Remove legacy ajax interface
Closed, ResolvedPublic
Actions

Description

MediaWiki has an old system for responding to AJAX requests that predates the action API. This system is implemented in the AjaxDispatcher class and controlled by the $wgAjaxExportList setting.

$wgAjaxExportList has been deprecated since 1.27. It was kept around to cover use cases that didn't fit well within the framework of the action API. However, these use cases can now be covered nicely with the new REST API, so the old AJAX interface should go away.

$wgAjaxExportList got removed for MediaWiki 1.38 in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/741941/

Next steps:

Details

Reference
bz40787
SubjectRepoBranchLines +/-
Remove legacy AJAX interface ($wgAjaxExportList) usage and convert the AJAX endpoints to regular api.php modulesmediawiki/extensions/CreateAPagemaster+444 -188
Remove more unused ajax response methodsmediawiki/coremaster+6 -18
Remove various unused AjaxResponse methodsmediawiki/coremaster+2 -105
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:01 AM
• bzimport added projects: Future-Release, MediaWiki-General, Tracking-Neverending.
• bzimport set Reference to bz40787.
• bzimport added a subscriber: Unknown Object (MLST).
DanielFriesen created this task.Oct 5 2012, 4:15 AM
Krenair subscribed.Dec 26 2014, 5:38 PM
• brooke subscribed.Jan 23 2015, 7:59 PM
Krenair mentioned this in T92777: Document deprecation of action=ajax and AjaxDispatcher.Mar 15 2015, 9:41 PM
TheDJ added a subtask: T92777: Document deprecation of action=ajax and AjaxDispatcher.Mar 15 2015, 11:42 PM
gerritbot subscribed.Aug 3 2015, 4:12 AM

Change 228768 had a related patch set uploaded (by Ori.livneh):
Remove Sajax

https://gerrit.wikimedia.org/r/228768

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2015, 4:12 AM
gerritbot added a project: Patch-For-Review.Aug 3 2015, 4:12 AM
Schnark subscribed.Aug 3 2015, 9:28 AM
Krenair added a subtask: T55120: Remove deprecated sajax js library from MediaWiki core.Aug 3 2015, 10:15 AM
Legoktm closed subtask T55120: Remove deprecated sajax js library from MediaWiki core as Resolved.Aug 4 2015, 5:48 PM
Krenair removed a subtask: T92777: Document deprecation of action=ajax and AjaxDispatcher.Aug 4 2015, 5:51 PM
Krenair removed a subtask: T42785: Remove sajax usage from MediaWiki core.
AdamCuerden reopened subtask T55120: Remove deprecated sajax js library from MediaWiki core as Stalled.Aug 6 2015, 2:21 PM
Krenair closed subtask T55120: Remove deprecated sajax js library from MediaWiki core as Resolved.Aug 6 2015, 3:16 PM
Ricordisamoa subscribed.Aug 8 2015, 8:47 PM
Liuxinyu970226 set Security to None.Dec 12 2015, 1:32 PM
Aklapper removed a project: Patch-For-Review.Dec 24 2015, 1:49 PM
Aklapper added a project: Technical-Debt.
Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.Jan 22 2016, 11:39 PM
Danny_B moved this task from Tag to Should be Goal instead on the Tracking-Neverending board.Jul 10 2016, 11:10 PM
Quiddity removed a parent task: T4007: [DO NOT USE] Tracking bug [superseded by #Tracking].Jul 14 2016, 3:18 AM
• Phabricator_maintenance removed a project: Future-Release.Aug 12 2016, 4:54 PM
• Phabricator_maintenance removed a subscriber: • wikibugs-l-list.
• Phabricator_maintenance added a project: Goal.Aug 13 2016, 8:42 PM
• Phabricator_maintenance renamed this task from Deprecate legacy ajax interface (tracking) to Deprecate legacy ajax interface.Aug 14 2016, 12:15 AM
• Phabricator_maintenance removed a project: Tracking-Neverending.
Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Jul 13 2018, 11:10 PM
Krinkle moved this task from Untriaged to 2016 | MW 1.27 / 1.28 on the Technical-Debt (Deprecation process) board.Jul 13 2018, 11:24 PM
Krinkle renamed this task from Deprecate legacy ajax interface to Remove legacy ajax interface.Jan 10 2019, 7:03 PM
Krinkle updated the task description. (Show Details)
gerritbot added a comment.Feb 28 2020, 2:41 PM

Change 575400 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] Remove various unused AjaxResponse methods

https://gerrit.wikimedia.org/r/575400

gerritbot added a project: Patch-For-Review.Feb 28 2020, 2:41 PM
gerritbot added a comment.Mar 1 2020, 3:37 AM

Change 575400 merged by jenkins-bot:
[mediawiki/core@master] Remove various unused AjaxResponse methods

https://gerrit.wikimedia.org/r/575400

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).Mar 1 2020, 4:00 AM
DannyS712 removed a project: Patch-For-Review.Mar 4 2020, 7:41 AM
gerritbot added a comment.Mar 4 2020, 7:44 AM

Change 576592 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove more unused ajax response methods

https://gerrit.wikimedia.org/r/576592

gerritbot added a project: Patch-For-Review.Mar 4 2020, 7:44 AM
DannyS712 subscribed.Mar 4 2020, 7:48 AM
gerritbot added a comment.Mar 7 2020, 11:03 AM

Change 576592 merged by jenkins-bot:
[mediawiki/core@master] Remove more unused ajax response methods

https://gerrit.wikimedia.org/r/576592

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.22; 2020-03-03).Mar 7 2020, 3:01 PM
Krinkle updated the task description. (Show Details)May 10 2020, 1:36 AM
Tgr mentioned this in T185664: Code stewardship review: FlaggedRevs.Jul 11 2020, 12:07 AM
Tgr mentioned this in T224922: Code Stewardship Review: Collection Extension.
Tgr mentioned this in T257703: Clean up Cache-Control handling in MediaWiki.Jul 11 2020, 12:11 AM
daniel edited projects, added TechCom, Platform Engineering; removed MW-1.35-notes (1.35.0-wmf.23; 2020-03-10).Dec 2 2020, 4:48 PM
daniel subscribed.

I just stumbled upon the fact that we still have this API-before-APIs in core. Let's please just kill it. This task has been open since the before-time (it was imported from bugzilla in 2014).

A handful of extensions still use it, porting them to using the action API or REST api should be simple enough. I suspect that most of them are unmaintained anyway.

• Clarakosi moved this task from Inbox to Tech Planning Review on the Platform Engineering board.Dec 8 2020, 9:28 PM
• Nikerabbit moved this task from Inbox to Watching on the TechCom board.Dec 15 2020, 11:37 AM
daniel updated the task description. (Show Details)Jan 14 2021, 11:06 AM
daniel updated the task description. (Show Details)
daniel edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering, Patch-For-Review, Goal.
This comment was removed by daniel.
daniel updated the task description. (Show Details)Jan 14 2021, 11:11 AM
daniel edited projects, added Platform Engineering Roadmap Decision Making; removed Platform Team Workboards (Clinic Duty Team).Jan 14 2021, 11:13 AM
daniel added a project: Platform Engineering.Jan 20 2021, 9:41 PM
daniel moved this task from Tech Planning Review to Future Initiatives/Small Projects on the Platform Engineering board.
ArielGlenn subscribed.Jan 21 2021, 10:05 AM
CCicalese_WMF moved this task from Untriaged to Code Jam on the Platform Engineering Roadmap Decision Making board.Feb 24 2021, 4:56 PM
CCicalese_WMF removed a project: Platform Engineering.Feb 24 2021, 11:38 PM
ashley subscribed.Feb 24 2021, 11:47 PM

Collection and MediaWiki-extensions-FlaggedRevs use this interface and are extensions used on WMF.

CreateAPage (which, I notice, doesn't even have a dedicated #hashtag here in Phab; I should fix that...) is maintained by me and also uses the AJAX interface.

Tim Starling did some work on the Wigo3 extension not that long time ago, so that one's not unmaintained either.

Krinkle added a comment.Feb 24 2021, 11:50 PM

Sub tasks that are (currently) blocking removal from core:

RhinosF1 updated the task description. (Show Details)Mar 16 2021, 6:51 AM
Restricted Application added a subscriber: RhinosF1. · View Herald TranscriptMar 16 2021, 6:51 AM
ashley added a project: CreateAPage.Apr 13 2021, 9:22 AM
daniel added a project: Platform Engineering Code Jam-2021.Jul 29 2021, 12:27 PM
daniel moved this task from Inbox to Ideas Q1 21/22 on the Platform Engineering Code Jam-2021 board.Jul 29 2021, 12:31 PM
• taavi subscribed.Aug 29 2021, 5:25 PM
DAlangi_WMF subscribed.Sep 10 2021, 1:42 PM
DAlangi_WMF updated the task description. (Show Details)Sep 15 2021, 11:41 PM
Umherirrender closed subtask T42786: Remove AjaxDispatcher from MediaWiki core as Resolved.Dec 18 2021, 4:16 PM
gerritbot added a comment.Jan 8 2022, 1:45 PM

Change 752265 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/CreateAPage@master] Remove legacy AJAX interface ($wgAjaxExportList) usage and convert the AJAX endpoints to regular api.php modules

https://gerrit.wikimedia.org/r/752265

gerritbot added a project: Patch-For-Review.Jan 8 2022, 1:45 PM
gerritbot added a comment.Feb 1 2022, 3:39 AM

Change 752265 merged by jenkins-bot:

[mediawiki/extensions/CreateAPage@master] Remove legacy AJAX interface ($wgAjaxExportList) usage and convert the AJAX endpoints to regular api.php modules

https://gerrit.wikimedia.org/r/752265

ashley mentioned this in rECPG34ee3488a31c: Remove legacy AJAX interface ($wgAjaxExportList) usage and convert the AJAX….Feb 1 2022, 3:42 AM
RhinosF1 mentioned this in T301178: Readd edit stash config variable.Feb 7 2022, 9:07 PM
Umherirrender removed a project: Patch-For-Review.Apr 9 2022, 5:47 PM
Umherirrender updated the task description. (Show Details)
Aklapper updated the task description. (Show Details)Jul 3 2022, 2:55 PM

Apart from 3rd party extensions (see tickets I've added in the task desc here) to update their code, is there anything actionable left in this task itself?

daniel closed this task as Resolved.Jul 4 2022, 9:17 AM
daniel claimed this task.
In T42787#8047161, @Aklapper wrote:

Apart from 3rd party extensions (see tickets I've added in the task desc here) to update their code, is there anything actionable left in this task itself?

Yep, seems like this is done.

Aklapper added a project: MW-1.38-release.Jul 4 2022, 9:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits