Create Task
Maniphest T94005

Remove AjaxDispatcher use from Collection
Closed, ResolvedPublic
Actions

Description

Still being used as of 2015:
https://github.com/wikimedia/mediawiki-extensions-Collection/blob/110e53d9/Collection.php#L259

This has been deprecated for many years now.

This has many problems including making translation impossible.

Details

SubjectRepoBranchLines +/-
Clean up JS and change action=ajax stuff into API modulesmediawiki/extensions/Collectionmaster+576 -514
Replace old ajax interface & use new api modules in client codemediawiki/extensions/Collectionmaster+335 -128
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Mar 26 2015, 6:26 AM
Krinkle raised the priority of this task from to High.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Technical-Debt, Collection.
Krinkle added a subscriber: Aklapper.
Krenair subscribed.Mar 26 2015, 2:45 PM

https://gerrit.wikimedia.org/r/#/c/183228/ would handle this

cscott claimed this task.Mar 31 2015, 6:18 PM
cscott subscribed.

I'm adopting Krenair's patch to split it apart, get it reviewed, and push it over the finish line.

gerritbot subscribed.Mar 31 2015, 7:05 PM

Change 183228 had a related patch set uploaded (by Cscott):
T94005: Clean up JS and change action=ajax stuff into API modules

https://gerrit.wikimedia.org/r/183228

gerritbot added a project: Patch-For-Review.Mar 31 2015, 7:05 PM
Krenair renamed this task from Remove AjaxDispatcher from Collection to Remove AjaxDispatcher use from Collection.May 20 2015, 2:01 PM
Krenair set Security to None.
Ricordisamoa subscribed.Jul 24 2015, 2:42 AM
Legoktm added a parent task: T87899: Convert Collection to use extension registration.Dec 17 2015, 10:31 PM
Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.Jan 22 2016, 11:47 PM
gerritbot added a comment.Aug 6 2016, 12:29 AM

Change 183228 had a related patch set uploaded (by Reedy):
[WIP] Clean up JS and change action=ajax stuff into API modules

https://gerrit.wikimedia.org/r/183228

gerritbot added a comment.Aug 13 2017, 5:53 PM

Change 183228 abandoned by Alex Monk:
[WIP] Clean up JS and change action=ajax stuff into API modules

https://gerrit.wikimedia.org/r/183228

gerritbot added a comment.Aug 15 2017, 11:25 PM

Change 183228 restored by Alex Monk:
[WIP] Clean up JS and change action=ajax stuff into API modules

Reason:
There were problems I was running into due to some mistakes while rebasing, and I gave up for a while. I'll look into fixing it later

https://gerrit.wikimedia.org/r/183228

Jdlrobson added a project: Web-Team-Backlog.Sep 5 2017, 7:05 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Sep 5 2017, 7:44 PM
Jdlrobson merged a task: T30057: [[Special:Book]] should pass "uselang" url parameter to AJAX requests.Sep 7 2017, 2:35 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: He7d3r, TerraCodes, Krinkle and 2 others.
Krinkle unsubscribed.Sep 22 2017, 6:16 PM
Jdlrobson moved this task from Triaged but Future to Tracking on the Web-Team-Backlog board.Sep 27 2017, 9:55 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
Jdlrobson moved this task from Untriaged to Move to Backlog on the Web-Team-Backlog (Tracking) board.Sep 28 2017, 7:35 PM
phuedx added subscribers: Jdlrobson, phuedx.Oct 9 2017, 4:33 PM

@Jdlrobson: Is Watching really the right place for this since you're trying to get the change merged?

Also, y'know, good luck!

Jdlrobson added subscribers: pmiazga, • bmansurov.Oct 9 2017, 4:37 PM

@bmansurov @pmiazga and I have agreed to focus on the rendering code and drop work on this since it doesn't help our cause so this patch is probably as far as it will go now sadly unless @cscott or someone else has bandwidth to help. We will watch it until that happens. There is a lot of work here to be done.

• bmansurov unsubscribed.Dec 22 2017, 9:47 PM
Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Jul 13 2018, 11:10 PM
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).Jul 13 2018, 11:21 PM
Krinkle removed a subscriber: • wikibugs-l-list.
Jdforrester-WMF subscribed.Jul 22 2019, 4:56 PM

The parent has been fixed ahead of this one with an ugly hack:

https://gerrit.wikimedia.org/g/mediawiki/extensions/Collection/+/690aaaddd36348b85a10984d6c6b59776f60fef3/includes/CollectionHooks.php

It'd be nice for this to get properly fixed.

Jdforrester-WMF removed a parent task: T87899: Convert Collection to use extension registration.Jul 22 2019, 4:56 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Jun 30 2020, 10:12 AM
TerraCodes unsubscribed.Jul 1 2020, 4:42 AM
Tgr mentioned this in T224922: Code Stewardship Review: Collection Extension.Jul 11 2020, 12:07 AM
Aklapper removed cscott as the assignee of this task.Dec 19 2020, 11:29 AM

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Krinkle mentioned this in T42787: Remove legacy ajax interface.Feb 24 2021, 11:50 PM
Jdlrobson moved this task from Move to Backlog to Untriaged on the Web-Team-Backlog (Tracking) board.Sep 7 2021, 9:05 PM
Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Sep 21 2021, 8:30 PM
tchin changed the status of subtask T291398: Turn usage of AJAX interface to API Modules (1) from Open to In Progress.Sep 24 2021, 3:43 PM
gerritbot added a comment.Oct 27 2021, 10:42 AM

Change 730621 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/Collection@master] Replace old ajax interface & use new api modules in client code

https://gerrit.wikimedia.org/r/730621

gerritbot added a project: Patch-For-Review.Oct 27 2021, 10:42 AM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptOct 27 2021, 10:42 AM
xSavitar changed the task status from Open to In Progress.Oct 27 2021, 10:44 AM
xSavitar assigned this task to DAlangi_WMF.
• Pchelolo closed subtask T291398: Turn usage of AJAX interface to API Modules (1) as Resolved.Nov 16 2021, 3:35 PM
gerritbot added a comment.Nov 18 2021, 4:12 PM

Change 730621 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Replace old ajax interface & use new api modules in client code

https://gerrit.wikimedia.org/r/730621

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 18 2021, 5:00 PM
phuedx unsubscribed.Nov 19 2021, 10:44 AM
Ladsgroup awarded a token.Nov 25 2021, 4:22 PM
Ladsgroup subscribed.

THANKS!!!!

DAlangi_WMF closed subtask T291399: Turn usage of AJAX interface to API Modules (2) as Resolved.Dec 2 2021, 5:02 PM

Done!

DAlangi_WMF closed this task as Resolved.Dec 2 2021, 5:03 PM
gerritbot added a comment.Jul 5 2022, 4:56 PM

Change 183228 abandoned by Jdlrobson:

[mediawiki/extensions/Collection@master] Clean up JS and change action=ajax stuff into API modules

Reason:

I don't remember, but given its age, I think we can just abandon this.

https://gerrit.wikimedia.org/r/183228

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits